Removing most (direct) connection usage in Pub / Sub #2874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Merged
tseaver
reviewed
Dec 15, 2016
| patch = mock.patch.multiple( | ||
| 'google.cloud.pubsub._gax', | ||
| PublisherClient=mock_publisher_api, | ||
| insecure_channel=mock_insecure_channel) | ||
| with patch: | ||
| result = self._call_fut(connection) | ||
| result = self._call_fut(None, host=host, secure=False) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
@dhermes I'm OK to merge without the change I suggested, if you don't think it would be an improvement. |
dhermes
force-pushed
the
gax-ignore-connection
branch
from
201fce2 to
c8a0d6e
Compare
|
@dhermes It looks to me as though if self.conn.in_emul:
channel = make_foo(host=emulator_host)
else:
channel = make_foo(credentials=credentials) |
Still using a method of a connection object, but this way it can be more easily swapped out for a function defined in that module doing the same task.
dhermes
force-pushed
the
gax-ignore-connection
branch
from
c8a0d6e to
80413c5
Compare
dhermes
force-pushed
the
gax-ignore-connection
branch
from
80413c5 to
a46184c
Compare
|
@tseaver PTAL |
|
LGTM |
This was referenced Dec 29, 2016
19 tasks
richkadel
pushed a commit
to richkadel/google-cloud-python
that referenced
this pull request
May 6, 2017
Removing most (direct) connection usage in Pub / Sub
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: Has #2870 as diffbase.