#295 let entity save accept null value for attribute #296

lucemia · 2014-10-27T04:18:19Z

Has unit test

lucemia · 2014-10-27T04:23:56Z

will still raise

/protobuf/internal/python_message.py in SerializeToString  `api.services.datastore.CommitRequest is missing required fields: mutation.upsert[0].property[2].value` exception in protobuf

coveralls · 2014-10-27T04:27:01Z

Coverage remained the same when pulling 3753821 on lucemia:support-null-value into b6d3e74 on GoogleCloudPlatform:master.

…eate but never assign value

coveralls · 2014-10-27T04:54:57Z

Coverage remained the same when pulling 014b658 on lucemia:support-null-value into b6d3e74 on GoogleCloudPlatform:master.

gcloud/datastore/helpers.py

@@ -222,6 +222,18 @@ def _set_protobuf_value(value_pb, val):
               :class:`gcloud.datastore.entity.Entity`,
    :param val: The value to be assigned.
    """
+    if val is None:
+        value_pb.ClearField('boolean_value')


gcloud/datastore/test_helpers.py

@@ -361,6 +361,20 @@ def test_key(self):
        value = pb.key_value
        self.assertEqual(value, key.to_protobuf())

+    def test_none(self):
+        pb = self._makePB()
+        self._callFUT(pb, None)


lucemia · 2014-10-28T14:51:25Z

@dhermes I didn't add NULL_PROPERTY = object() in current pull request yet because I think there are pros and cons to add sentinel value.

coveralls · 2014-10-28T14:52:38Z

Coverage remained the same when pulling a208132 on lucemia:support-null-value into b6d3e74 on GoogleCloudPlatform:master.

tseaver · 2014-10-28T15:02:57Z

LGTM.

-1 on a sentinel: _set_protobuf_value() is not an API, it only gets values from those stored in Entities, and from the filter(expr, value) method of a Query: in both cases, None is the more Pythonic way to express what the user expects, and there is no notion of a "default".

tseaver · 2014-10-28T15:04:24Z

Note that we already return None from _get_value_from_value_pb() in the case that none of the fields has been set.

#295 let entity save accept null value for attribute

Add Drive.get_item_by_path(item_path)

…tage for the UploadConversation API when creating Analyses in Insights (#296) * feat: add a way to specify the conversation automatic analysis percentage for the UploadConversation API when creating Analyses in Insights PiperOrigin-RevId: 513416013 Source-Link: googleapis/googleapis@dacdbc8 Source-Link: googleapis/googleapis-gen@7e3cf93 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiN2UzY2Y5MzMwMDA0NWU5YTVjYmZiMTkwMDJkMWNkNGNiOTNiMDZkMCJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

Source-Link: googleapis/synthtool@56da63e Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:993a058718e84a82fda04c3177e58f0a43281a996c7c395e0a56ccc4d6d210d7

Co-authored-by: Anthonios Partheniou <partheniou@google.com>

Source-Link: googleapis/synthtool@7197a00 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:c43f1d918bcf817d337aa29ff833439494a158a0831508fda4ec75dc4c0d0320 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

Source-Link: googleapis/synthtool@38e11ad Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:4e1991042fe54b991db9ca17c8fb386e61b22fe4d1472a568bf0fcac85dcf5d3

* chore: use gapic-generator-python 0.65.2 PiperOrigin-RevId: 444333013 Source-Link: googleapis/googleapis@f91b6cf Source-Link: googleapis/googleapis-gen@16eb360 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMTZlYjM2MDk1YzI5NGU3MTJjNzRhMWJmMjM1NTA4MTdiNDIxNzRlNSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

* fix: fix path to products files. * Fix path creation. Move gcs bucket creation logic to the function. Co-authored-by: nicain <nicholascain@google.com> Co-authored-by: Anthonios Partheniou <partheniou@google.com>

* docs: Fix formatting of request arg in docstring chore: Update gapic-generator-python to v1.9.1 PiperOrigin-RevId: 518604533 Source-Link: googleapis/googleapis@8a085ae Source-Link: googleapis/googleapis-gen@b2ab4b0 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYjJhYjRiMGEwYWUyOTA3ZTgxMmMyMDkxOThhNzRlMDg5OGFmY2IwNCJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

…296) * feat: add cloud spanner connection properties - serverless analytics feat: add cloud spanner connection properties - database role PiperOrigin-RevId: 511807110 Source-Link: googleapis/googleapis@a563815 Source-Link: googleapis/googleapis-gen@a28f65a Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYTI4ZjY1YWNhY2UxMjUwNGRmZTQ0OGIyYmRjNTUxM2VlODk4NjI2NSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * chore: Update gapic-generator-python to v1.8.5 PiperOrigin-RevId: 511892190 Source-Link: googleapis/googleapis@a45d9c0 Source-Link: googleapis/googleapis-gen@1907294 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMTkwNzI5NGIxZDgzNjVlYTI0ZjhjNWYyZTA1OWE2NDEyNGM0ZWQzYiJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * chore: Fixed Ruby documentation generation PiperOrigin-RevId: 512672271 Source-Link: googleapis/googleapis@bc22d91 Source-Link: googleapis/googleapis-gen@cad484d Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiY2FkNDg0ZDRkYmRjNDM0YmFiOWJkZWIxN2NkZDA3ODQ1N2M3YzcwZCJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <partheniou@google.com>

…[autoapprove] (#296) Source-Link: googleapis/synthtool@1f37ce7 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:8e84e0e0d71a0d681668461bba02c9e1394c785f31a10ae3470660235b673086

- [ ] Regenerate this pull request now. docs: list oneofs in docstring fix(deps): require google-api-core >= 1.28.0 fix(deps): drop packaging dependency committer: busunkim96@ PiperOrigin-RevId: 406468269 Source-Link: googleapis/googleapis@83d81b0 Source-Link: googleapis/googleapis-gen@2ff001f Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMmZmMDAxZmJhY2I5ZTc3ZTcxZDczNGRlNWY5NTVjMDVmZGFlODUyNiJ9

- [ ] Regenerate this pull request now. PiperOrigin-RevId: 413780624 Source-Link: googleapis/googleapis@ed9918e Source-Link: googleapis/googleapis-gen@9286ba6 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiOTI4NmJhNjBlMWMxZjZiY2Q1NTllOTgzNDc1NmIyZmEzZTUxZjI2ZCJ9 feat: added field for BigQuery inspect template inclusion lists feat: added field to support infotype versioning

🤖 I have created a release \*beep\* \*boop\* --- ## [3.4.0](https://www.github.com/googleapis/python-dlp/compare/v3.3.1...v3.4.0) (2021-12-03) ### Features * added deidentify replacement dictionaries ([#296](https://www.github.com/googleapis/python-dlp/issues/296)) ([63e9661](https://www.github.com/googleapis/python-dlp/commit/63e96614ba72e4ae8e0eafe4139d5329e75a3c18)) * added field for BigQuery inspect template inclusion lists ([63e9661](https://www.github.com/googleapis/python-dlp/commit/63e96614ba72e4ae8e0eafe4139d5329e75a3c18)) * added field to support infotype versioning ([63e9661](https://www.github.com/googleapis/python-dlp/commit/63e96614ba72e4ae8e0eafe4139d5329e75a3c18)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

…pprove] (#296) Source-Link: https://togithub.com/googleapis/synthtool/commit/e3a1277ac35fc88c09db1930533e24292b132ced Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:452901c74a22f9b9a3bd02bce780b8e8805c97270d424684bff809ce5be8c2a2

Source-Link: googleapis/synthtool@703554a Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:94961fdc5c9ca6d13530a6a414a49d2f607203168215d074cdb0a1df9ec31c0b

🤖 I have created a release \*beep\* \*boop\* --- ## [3.6.0](https://www.github.com/googleapis/python-asset/compare/v3.5.0...v3.6.0) (2021-09-24) ### Bug Fixes * add 'dict' annotation type to 'request' ([79a5a8a](https://www.github.com/googleapis/python-asset/commit/79a5a8a11d49c52162b9467e291df38f70634858)) ### Documentation * add relationship samples ([#293](https://www.github.com/googleapis/python-asset/issues/293)) ([473e133](https://www.github.com/googleapis/python-asset/commit/473e133e2674bf6a5ae655fe67be7d79fed2d8e9)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

Source-Link: googleapis/synthtool@d2871d9 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:b2dc5f80edcf5d4486c39068c9fa11f7f851d9568eea4dcba130f994ea9b5e97 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

* chore: update Java and Python dependencies PiperOrigin-RevId: 408420890 Source-Link: googleapis/googleapis@2921f9f Source-Link: googleapis/googleapis-gen@6598ca8 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNjU5OGNhOGNiYmY1MjI2NzMzYTA5OWM0NTA2NTE4YTVhZjZmZjc0YyJ9 * 🦉 Updates from OwlBot See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

Source-Link: googleapis/synthtool@4760d8d Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:f0e4b51deef56bed74d3e2359c583fc104a8d6367da3984fc5c66938db738828 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

* feat: Add an enum value for raw locations from Apple platforms PiperOrigin-RevId: 476961484 Source-Link: googleapis/googleapis@695134b Source-Link: googleapis/googleapis-gen@49457f9 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNDk0NTdmOWU3YWFlODljZmUwNDkxYWY0ZGJkOTk2MWE5MDEyNWQzMiJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

* chore: Update gapic-generator-python to v1.18.0 PiperOrigin-RevId: 638650618 Source-Link: googleapis/googleapis@6330f03 Source-Link: googleapis/googleapis-gen@44fa4f1 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNDRmYTRmMTk3OWRjNDVjMTc3OGZkN2NhZjEzZjhlNjFjNmQxY2FlOCJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

googleapis#295 let entity save accept null value for attribute

3753821

fix an issue that protoc buff will raise exception if a _pb object cr…

014b658

…eate but never assign value

dhermes reviewed Oct 27, 2014
View reviewed changes

dhermes mentioned this pull request Oct 27, 2014

Implements group_by, projection and offset on datastore Query. #282

Merged

tseaver reviewed Oct 27, 2014
View reviewed changes

gcloud/datastore/test_helpers.py

@@ -361,6 +361,20 @@ def test_key(self):

value = pb.key_value

self.assertEqual(value, key.to_protobuf())

def test_none(self):

pb = self._makePB()

self._callFUT(pb, None)

This comment was marked as spam.

Sign in to view

silvolu added the cla: yes This human has signed the Contributor License Agreement. label Oct 27, 2014

fix the helper function and test case while checking null value

a208132

tseaver added a commit that referenced this pull request Oct 28, 2014

Merge pull request #296 from lucemia/support-null-value

7d9bfb1

#295 let entity save accept null value for attribute

tseaver merged commit 7d9bfb1 into googleapis:master Oct 28, 2014

tseaver mentioned this pull request Oct 28, 2014

datastore support set null value #295

Closed

lucemia deleted the support-null-value branch November 28, 2014 03:37

urshala pushed a commit to urshala/google-cloud-python that referenced this pull request Jan 17, 2020

Merge pull request googleapis#296 from cg6/master

5280685

Add Drive.get_item_by_path(item_path)

atulep pushed a commit that referenced this pull request Apr 3, 2023

chore: update .repo-metadata.json (#296)

f3cea7f

atulep pushed a commit that referenced this pull request Apr 6, 2023

chore: update .repo-metadata.json (#296)

d579156

atulep pushed a commit that referenced this pull request Apr 6, 2023

chore: update .repo-metadata.json (#296)

0497c40

atulep pushed a commit that referenced this pull request Apr 18, 2023

chore: update .repo-metadata.json (#296)

f2e0eb8

parthea pushed a commit that referenced this pull request Jun 4, 2023

chore(deps): update dependency pytest to v7.1.1 (#296)

3ad7023

parthea added a commit that referenced this pull request Jun 4, 2023

chore(deps): update dependency pytest to v7 (#296)

2e1a027

Co-authored-by: Anthonios Partheniou <partheniou@google.com>

parthea pushed a commit that referenced this pull request Jun 4, 2023

chore(deps): update dependency google-cloud-talent to v2.7.2 (#296)

cffc726

parthea pushed a commit that referenced this pull request Jul 6, 2023

chore(deps): update dependency google-auth to v2.6.3 (#296)

24f6310

parthea added a commit that referenced this pull request Aug 15, 2023

chore: prepare for monorepo migration (#296)

1cff7d1

vchudnov-g pushed a commit that referenced this pull request Sep 20, 2023

chore(deps): update dependency google-cloud-dialogflow to v2.2.0 (#296)

11753b1

parthea added a commit that referenced this pull request Oct 21, 2023

chore: configure release-please to use manifest (#296)

ab8f72a

parthea added a commit that referenced this pull request Oct 22, 2023

chore: update .repo-metadata.json (#296)

038e9c2

parthea pushed a commit that referenced this pull request Oct 22, 2023

chore(deps): update dependency google-cloud-trace to v1.10.0 (#296)

cd8b4ba

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#295 let entity save accept null value for attribute #296

#295 let entity save accept null value for attribute #296

lucemia commented Oct 27, 2014

lucemia commented Oct 27, 2014

coveralls commented Oct 27, 2014

coveralls commented Oct 27, 2014

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

lucemia commented Oct 28, 2014

coveralls commented Oct 28, 2014

tseaver commented Oct 28, 2014

tseaver commented Oct 28, 2014