Ensure that 'Session' instances are orderable. #3042
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
daspecster
reviewed
Feb 17, 2017
| def __init__(self, database): | ||
| self._database = database | ||
|
|
||
| def __lt__(self, other): |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Contributor
dhermes
approved these changes
Feb 18, 2017
Contributor
|
@tseaver You are red on Travis CI (indicates docs or lint is failing, they don't yet run on CircleCI) |
Some pools store them in priority queues, with a leading timestamp: if two entries have the same timestamp, then the sessions need to be orderable.
19 tasks
richkadel
pushed a commit
to richkadel/google-cloud-python
that referenced
this pull request
May 6, 2017
…-timestamp-race Ensure that 'Session' instances are orderable.
parthea
pushed a commit
that referenced
this pull request
Oct 21, 2023
…gleCloudPlatform/python-docs-samples#3042) * automl: move video classification samples out of branch * fix uuid and create test * fix project * use global for testing * Update video_classification_create_model.py Co-authored-by: Leah E. Cole <6719667+leahecole@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also the mocked-up versions used to test pools.
Rationale: Some pools store them in priority queues, with a leading timestamp: if two entries have the same timestamp, then the sessions need to be orderable.
Closes #3011.