Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix storage encryption example, remove policy document example. #3221

Merged
merged 1 commit into from
Mar 28, 2017
Merged

Fix storage encryption example, remove policy document example. #3221

merged 1 commit into from
Mar 28, 2017

Conversation

daspecster
Copy link
Contributor

This removes the policy document example. I'm not sure why it's failing at the moment.

Also adds a line to the encryption key example to make it work out of the box.

@daspecster daspecster added api: storage Issues related to the Cloud Storage API. docs labels Mar 28, 2017
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 28, 2017
@daspecster daspecster mentioned this pull request Mar 28, 2017
Closed
24 tasks
dhermes
dhermes reviewed Mar 28, 2017
View reviewed changes
Copy link
Contributor

@dhermes dhermes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should ask @jonparrott to help with the failure. Removing the example doesn't stop the feature from being broken?

docs/storage_snippets.py Outdated
@@ -138,7 +139,8 @@ def delete_blob(client, to_delete):
from google.cloud.exceptions import NotFound
client = storage.Client()
bucket = client.get_bucket('my-bucket')
assert isinstance(bucket.list_blobs(), list)
blobs = list(bucket.list_blobs())
assert isinstance(blobs, list)

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@daspecster
Copy link
Contributor Author

@dhermes #3172 (comment)

@dhermes
Copy link
Contributor

dhermes commented Mar 28, 2017

@daspecster I saw his comment, but didn't interpret it as "I give up forever"

@daspecster
Copy link
Contributor Author

@dhermes sorry, I'm just trying to get through all this before the GA so there's at least a record of things that may be broken.

I may have taken @lukesneeringer's comment in the meeting about removing examples to far in this case?

@daspecster daspecster added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Mar 28, 2017
@daspecster
Copy link
Contributor Author

Added "do not merge" label until #3222 is figured out.

@dhermes
Copy link
Contributor

dhermes commented Mar 28, 2017

@daspecster You can just restore that example so you don't need to block this PR, then settle what is to be settled in #3222

@daspecster
Copy link
Contributor Author

@dhermes restored!

@daspecster daspecster force-pushed the update-storage-snippets branch from 1e10d2a to 358bf5f Compare March 28, 2017 17:14
@lukesneeringer
Copy link
Contributor

I may have taken @lukesneeringer's comment in the meeting about removing examples to far in this case?

No, you were right. If we cannot fix the code in time, I would prefer remove the example. No example (and an issue to fix the bug) is better than an example that fails.

@daspecster
Copy link
Contributor Author

@lukesneeringer ok I'll rebase the last commit out and then we should be good on this one?

@daspecster daspecster force-pushed the update-storage-snippets branch from 358bf5f to 3f7c92e Compare March 28, 2017 17:30
@lukesneeringer
Copy link
Contributor

Yes, with the caveat that definitely make an effort to fix the bug. :-)

@lukesneeringer lukesneeringer merged commit 081f93a into googleapis:master Mar 28, 2017
@daspecster daspecster removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Mar 28, 2017
@daspecster daspecster deleted the update-storage-snippets branch March 28, 2017 21:39
richkadel pushed a commit to richkadel/google-cloud-python that referenced this pull request May 6, 2017
@daspecster @lukesneeringer
Fix encryption example, remove document policy example. (googleapis#3221
affdd28 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhermes dhermes dhermes left review comments

@tseaver tseaver tseaver left review comments

Assignees

@lukesneeringer lukesneeringer

@tseaver tseaver

Labels
api: storage Issues related to the Cloud Storage API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@daspecster @dhermes @lukesneeringer @tseaver @googlebot