Fix new partitioned table

[richkadel]

[This is a re-do of the pull request #3366 to fix the author email address to use my google.com email]

I moved the partitioning_type check into the if / elif block to avoid a ValueError that should not have been thrown.

See:
https://cloud.google.com/bigquery/docs/creating-partitioned-tables#creating_a_partitioned_table and the "API" example.

Before my change, the following code failed with the ValueError thrown by this function, but with my change, I was able to successfully create the partitioned table:

destination_table = dataset.table(table_shortname)

if not destination_table.exists(): 
    destination_table.partitioning_type = 'DAY'
    destination_table.create()

# Use a table partition
destination_partition = dataset.table(table_shortname + '$' + partition_date)

[richkadel]

@dhermes @jonparrott
I resubmitted my changes in a new pull request to make sure it has my @google.com email, and withdrew pull request #3366

[dhermes]

Thanks @richkadel. This LGTM.

@tswast Any issues?

[dhermes]

@richkadel Your code snippet above never uses destination_partition. Is there a typo somewhere?

[richkadel]

@dhermes re: @richkadel Your code snippet above never uses destination_partition. Is there a typo somewhere?

No typo. The code that uses the partition itself is not shown. I left the line in to show that the table name used in the "create" call is the table name without the partition suffix. Once the table is created then you can use destination_partition value as the "job_destination" setting to materialize data into just that partition.

[dhermes]

@richkadel Gotcha, I just made an edit to make that clearer.

[richkadel]

Updates have been pushed and all tests pass.

[tswast]

Thank you!

[dhermes]

OK @jonparrott also thinks this looks just fine.