Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 'Query.num_dml_affected_rows' property. #3460

Merged
merged 1 commit into from
May 31, 2017
Merged

Add 'Query.num_dml_affected_rows' property. #3460

merged 1 commit into from
May 31, 2017

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented May 31, 2017

Read-only, set from servier-provided numDmlAffectedRows field.

Closes #2920.

@tseaver tseaver added api: bigquery Issues related to the BigQuery API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels May 31, 2017
@tseaver tseaver requested review from tswast and dhermes May 31, 2017 17:15
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 31, 2017
dhermes
dhermes approved these changes May 31, 2017
View reviewed changes
Copy link
Contributor

@dhermes dhermes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but @tseaver can you hold-off merging until @tswast has a look?

@dhermes
Copy link
Contributor

dhermes commented May 31, 2017

@tseaver CI is red for a missed coverage line

tswast
tswast approved these changes May 31, 2017
View reviewed changes
Copy link
Contributor

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tseaver
Add 'Query.num_dml_affected_rows' property.
c9e6a40 
Read-only, set from servier-provided 'numDmlAffectedRows' field.

Closes #2920.
@tseaver
Copy link
Contributor Author

tseaver commented May 31, 2017

@dhermes Odd, a bare nox passed fine on this branch on my local machine. I've pushed a change which should fix it.

@tseaver tseaver merged commit 7e73e78 into googleapis:master May 31, 2017
@tseaver tseaver deleted the 2920-bigquery-num_dml_affected_rows branch May 31, 2017 17:54
@tseaver tseaver mentioned this pull request May 31, 2017
Closed
@tseaver tseaver mentioned this pull request Jun 26, 2017
Merged
landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 21, 2017
@tseaver @landrito
Add 'Query.num_dml_affected_rows' property. (googleapis#3460)
9e44ba0 
Read-only, set from servier-provided 'numDmlAffectedRows' field.

Closes googleapis#2920.
landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 22, 2017
@tseaver @landrito
Add 'Query.num_dml_affected_rows' property. (googleapis#3460)
3d6adcd 
Read-only, set from servier-provided 'numDmlAffectedRows' field.

Closes googleapis#2920.
landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 22, 2017
@tseaver @landrito
Add 'Query.num_dml_affected_rows' property. (googleapis#3460)
84bb5d0 
Read-only, set from servier-provided 'numDmlAffectedRows' field.

Closes googleapis#2920.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhermes dhermes dhermes approved these changes

@tswast tswast tswast approved these changes

Assignees
No one assigned
Labels
api: bigquery Issues related to the BigQuery API. cla: yes This human has signed the Contributor License Agreement. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tseaver @dhermes @tswast @googlebot