Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making requirements tighter for "stable" packages in 0.25.1 release. #3584

Merged
merged 1 commit into from
Jul 6, 2017

Conversation

dhermes
Copy link
Contributor

@dhermes dhermes commented Jul 6, 2017

See #3579 for context.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 6, 2017
@dhermes dhermes mentioned this pull request Jul 6, 2017
@dhermes
Copy link
Contributor Author

dhermes commented Jul 6, 2017

All relevant google-cloud-datastore "stable" releases:

$ git show datastore-1.0.0:datastore/setup.py | grep -A 4 'REQUIREMENTS = \['
REQUIREMENTS = [
    'google-cloud-core >= 0.24.0, < 0.25dev',
    'google-gax>=0.15.7, <0.16dev',
    'gapic-google-cloud-datastore-v1 >= 0.15.0, < 0.16dev',
]

All relevant google-cloud-logging "stable" releases:

$ git show logging-1.0.0:logging/setup.py | grep -A 4 'REQUIREMENTS = \['
REQUIREMENTS = [
    'google-cloud-core >= 0.24.0, < 0.25dev',
    'grpcio >= 1.2.0, < 2.0dev',
    'gapic-google-cloud-logging-v2 >= 0.91.0, < 0.92dev',
]

All relevant google-cloud-storage "stable" releases:

$ git show storage-1.1.0:storage/setup.py | grep -A 5 'REQUIREMENTS = \['
REQUIREMENTS = [
    'google-cloud-core >= 0.24.1, < 0.25dev',
    'google-auth >= 1.0.0',
    'google-resumable-media == 0.0.2',
    'requests >= 2.0.0',
]
$
$ git show storage-1.1.1:storage/setup.py | grep -A 5 'REQUIREMENTS = \['
REQUIREMENTS = [
    'google-cloud-core >= 0.24.1, < 0.25dev',
    'google-auth >= 1.0.0',
    'google-resumable-media == 0.0.2',
    'requests >= 2.0.0',
]

ISTM that google-cloud-storage==1.0.0 was never included in an umbrella release?

@dhermes
Copy link
Contributor Author

dhermes commented Jul 6, 2017

Also a thorn in our sides, all relevant google-cloud-error-reporting "stable" releases:

$ git show error-reporting-0.24.2:error_reporting/setup.py | \
> grep -A 4 'REQUIREMENTS = \['
REQUIREMENTS = [
    'google-cloud-core >= 0.24.1, < 0.25dev',
    'google-cloud-logging >= 1.0.0, < 2.0dev',
    'gapic-google-cloud-error-reporting-v1beta1 >= 0.15.0, < 0.16dev'
]

and google-cloud-error-reporting is the only package that depends on another:

$ git grep "'google-cloud-" -- '*/setup.py' | \
> egrep -v google-cloud-core | \
> egrep -v "name="
error_reporting/setup.py:    'google-cloud-logging >= 1.0.0, < 2.0dev',

@dhermes dhermes force-pushed the fix-3579-in-0.25.0 branch from edf39a3 to 22d8b29 Compare July 6, 2017 19:57
@dhermes
Copy link
Contributor Author

dhermes commented Jul 6, 2017

Merging with permission of @lukesneeringer

@dhermes dhermes merged commit ad4b02c into googleapis:at-tag-0.25.0 Jul 6, 2017
@dhermes dhermes deleted the fix-3579-in-0.25.0 branch July 6, 2017 20:28
@dhermes
Copy link
Contributor Author

dhermes commented Jul 6, 2017

New release pushed:
https://github.com/GoogleCloudPlatform/google-cloud-python/releases/tag/0.25.1

Here is the CircleCI build that should push to PyPI:
https://circleci.com/gh/GoogleCloudPlatform/google-cloud-python/2327

However, I may end up having to do it by hand due to current build issues (which is "just fine").

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement. packaging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants