Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BigQuery: Remove client-side enum validation. #3735

Merged
merged 1 commit into from
Aug 7, 2017
Merged

BigQuery: Remove client-side enum validation. #3735

merged 1 commit into from
Aug 7, 2017

Conversation

lukesneeringer
Copy link
Contributor

Fixes #3725.

@lukesneeringer lukesneeringer self-assigned this Aug 7, 2017
@lukesneeringer lukesneeringer requested a review from tseaver August 7, 2017 14:50
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 7, 2017
dhermes
dhermes approved these changes Aug 7, 2017
View reviewed changes
Copy link
Contributor

@dhermes dhermes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bigquery/tests/unit/test__helpers.py
@@ -765,7 +765,7 @@ def _get_target_class():
def test_it(self):

class Sub(self._get_target_class()):
ALLOWED = ('FOO', 'BAR', 'BAZ')
pass

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@lukesneeringer lukesneeringer merged commit b09eda9 into googleapis:master Aug 7, 2017
@lukesneeringer lukesneeringer deleted the issue-3725 branch August 7, 2017 16:16
landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 21, 2017
@lukesneeringer @landrito
BigQuery: Remove client-side enum validation. (googleapis#3735)
2fe57c1
landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 22, 2017
@lukesneeringer @landrito
BigQuery: Remove client-side enum validation. (googleapis#3735)
f206acd
landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 22, 2017
@lukesneeringer @landrito
BigQuery: Remove client-side enum validation. (googleapis#3735)
a1f9bc7
@lukesneeringer lukesneeringer mentioned this pull request Aug 24, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhermes dhermes dhermes approved these changes

@tseaver tseaver Awaiting requested review from tseaver

Assignees

@lukesneeringer lukesneeringer

Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lukesneeringer @tseaver @dhermes @googlebot