Document retry of exceptions while streaming 'read'/'execute_sql' results #3790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tseaver
added
api: spanner
googlebot
added
the
cla: yes
theacodes
approved these changes
Aug 11, 2017
lukesneeringer
approved these changes
Aug 11, 2017
vkedia
reviewed
Aug 11, 2017
| print row | ||
| except Exception: | ||
| result = snapshot.read( | ||
| table, columns, keys, resume_token=result.resume_token) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
@vkedia The |
|
Yes but each successful fetch might not have a resume_token. Also the StreamedResultSet returns the resume_token from the last PRS to the user even though the PRS itself might not have been yielded to the user since it does not form a complete row yet. That will lead to problem 2 I mentioned. |
landrito
pushed a commit
to landrito/google-cloud-python
that referenced
this pull request
Aug 21, 2017
landrito
pushed a commit
to landrito/google-cloud-python
that referenced
this pull request
Aug 22, 2017
landrito
pushed a commit
to landrito/google-cloud-python
that referenced
this pull request
Aug 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: #3775.
This PR does not close that issue: it only documents the actual, current retry semantics, instead of the intended-but-not-yet-implemented semantics in the current docs.