Use metadata server to detect GKE environment #3856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liyanhui1228
requested review from
lukesneeringer,
theacodes,
dhermes and
duggelz
googlebot
added
the
cla: yes
lukesneeringer
approved these changes
Aug 23, 2017
theacodes
reviewed
Aug 23, 2017
| try: | ||
| response = requests.get(url, headers=METADATA_HEADERS) | ||
|
|
||
| if response.status_code == requests.codes.ok: |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
duggelz
reviewed
Aug 23, 2017
| See: https://cloud.google.com/compute/docs/storing-retrieving-metadata | ||
|
|
||
| :type metadata_key: str | ||
| :param metadata_key: Key of the metadata which will form the url. |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
logging/tests/unit/test__helpers.py
Outdated
|
|
||
| def test_request_exception(self): | ||
| metadata_key = 'test_url_cannot_connect' | ||
| metadata_url = 'invalid_url' |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
duggelz
approved these changes
Aug 23, 2017
|
@dhermes Danny could you please do a final pass for this and merge if looks good? |
theacodes
approved these changes
Aug 23, 2017
|
LGTM, will merge once CI completes. |
|
Thanks @jonparrott! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #3622. This fixes the
get_default_handler()method to let it return theContainerEngineHandlerwhen in GKE environment using thecluster_nameattribute from the metadata server. If this attribute exists, it should be in GKE environment.