Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BQ: remove redundant __eq__ from Query Parameters. #4055

Merged
merged 1 commit into from
Sep 25, 2017
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 0 additions & 24 deletions bigquery/google/cloud/bigquery/_helpers.py
Original file line number Diff line number Diff line change
Expand Up @@ -527,14 +527,6 @@ def __init__(self, name, type_, value):
self.type_ = type_
self.value = value

def __eq__(self, other):
if not isinstance(other, ScalarQueryParameter):
return NotImplemented
return(
self.name == other.name and
self.type_ == other.type_ and
self.value == other.value)

@classmethod
def positional(cls, type_, value):
"""Factory for positional paramater.
Expand Down Expand Up @@ -637,14 +629,6 @@ def __init__(self, name, array_type, values):
self.array_type = array_type
self.values = values

def __eq__(self, other):
if not isinstance(other, ArrayQueryParameter):
return NotImplemented
return(
self.name == other.name and
self.array_type == other.array_type and
self.values == other.values)

@classmethod
def positional(cls, array_type, values):
"""Factory for positional parameters.
Expand Down Expand Up @@ -789,14 +773,6 @@ def __init__(self, name, *sub_params):
types[sub.name] = sub.type_
values[sub.name] = sub.value

def __eq__(self, other):
if not isinstance(other, StructQueryParameter):
return NotImplemented
return(
self.name == other.name and
self.struct_types == other.struct_types and
self.struct_values == other.struct_values)

@classmethod
def positional(cls, *sub_params):
"""Factory for positional parameters.
Expand Down