-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move debug statement with blocking future.result() call to add_done_callback #4174
Conversation
@@ -139,9 +139,12 @@ def on_response(self, response): | |||
|
|||
For each message, schedule a callback with the executor. | |||
""" | |||
def callback_completed(future): | |||
logger.debug('Result: %s' % future.result()) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Thanks @jeffkpayne! |
@lukesneeringer NP! Funny, though, I was just working on a unit test to test that the calls actually happen asynchronously... Should I continue with that and open a new PR? |
It would be along the lines of:
|
I would accept that as a system test (but not a unit test). :-) And yes, additional PR is of course welcome. |
P. S. pubsub 0.28.4 is going through CI to release now. (This was a serious enough bug that I wanted it out immediately.) |
@lukesneeringer The Pub / Sub unit tests seem to be broken (or heisen-broken) on Python 2.7: |
…allbacks to complete. Guessing this test was succeeding before because of the bug fixed in googleapis#4174 itself.
Closes #4167