Pub/Sub autogen refresh #4297
Closed
Pub/Sub autogen refresh #4297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukesneeringer
added
api: pubsub
googlebot
added
the
cla: yes
lukesneeringer
removed
the
do not merge
|
This now seems to be in good shape. Lobbing to @jonparrott for review. |
|
@lukesneeringer FYI #4296 is an uber-release, but I was planning on checking on you before actually pushing the tag for Pub/Sub. |
theacodes
approved these changes
Oct 31, 2017
| from google.protobuf import field_mask_pb2 | ||
|
|
||
| _GAPIC_LIBRARY_VERSION = pkg_resources.get_distribution( | ||
| 'google-cloud-pubsub', ).version |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| credentials=credentials, | ||
| scopes=self._DEFAULT_SCOPES) | ||
|
|
||
| self.iam_policy_stub = (iam_policy_pb2.IAMPolicyStub(channel)) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
tseaver
added
priority: p2
|
Closing in favor or #4438 (which literally pushed this exact set of history to start). But that PR is in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a merger of Pub/Sub with
google.api_core. Markeddo not mergewhile Ernest and I work out some khinks.