-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
api_core: Add routing header #4336
Merged
Merged
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,43 @@ | ||
# Copyright 2017 Google LLC | ||
# | ||
# Licensed under the Apache License, Version 2.0 (the "License"); | ||
# you may not use this file except in compliance with the License. | ||
# You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
|
||
"""Helpers for handling routing header params.""" | ||
|
||
|
||
try: | ||
from urllib.parse import urlencode | ||
except ImportError: | ||
def urlencode(params): | ||
return '&'.join(['{}={}'.format(*pair) for pair in params]) | ||
|
||
ROUTING_METADATA_KEY = 'x-goog-header-params' | ||
|
||
|
||
def _to_url_string(x): | ||
This comment was marked as spam.
Sorry, something went wrong. |
||
if not isinstance(x, bool): | ||
return str(x) | ||
elif x: | ||
return '1' | ||
else: | ||
return '0' | ||
|
||
|
||
def to_routing_header(params): | ||
"""Returns the routing header string that the params form""" | ||
return urlencode([(k, _to_url_string(v)) for k, v in params]) | ||
|
||
|
||
def to_grpc_metadata(params): | ||
"""Returns the gRPC metadata that the routing header params form""" | ||
return (ROUTING_METADATA_KEY, to_routing_header(params)) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
# Copyright 2017 Google LLC | ||
# | ||
# Licensed under the Apache License, Version 2.0 (the "License"); | ||
# you may not use this file except in compliance with the License. | ||
# You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
|
||
|
||
from google.api_core.gapic_v1 import routing_header | ||
|
||
|
||
def test_to_routing_header(): | ||
params = [('name', 'meep'), ('book.read', True)] | ||
value = routing_header.to_routing_header(params) | ||
assert value == "name=meep&book.read=1" | ||
|
||
|
||
def test_to_grpc_metadata(): | ||
params = [('name', 'meep'), ('book.read', True)] | ||
metadata = routing_header.to_grpc_metadata(params) | ||
assert metadata == ( | ||
routing_header.ROUTING_METADATA_KEY, "name=meep&book.read=1") |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This comment was marked as spam.
Sorry, something went wrong.