Skip to content

WIP: Spanner: Bad constructor behavior #4502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
chemelnucfin wants to merge 1 commit into from
Closed

WIP: Spanner: Bad constructor behavior #4502

chemelnucfin wants to merge 1 commit into from

Conversation

@chemelnucfin
Copy link
Contributor

@chemelnucfin chemelnucfin commented Nov 30, 2017 •
edited
Loading

According to the documents, https://cloud.google.com/spanner/docs/reference/rest/v1/KeySet,
these should be errors. This came up when I was looking at partial ranges.
The to_pb method does not work if the keys aren't specified.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 30, 2017
@chemelnucfin chemelnucfin changed the title Spanner: ctor bad behavior Spanner: Constructor bad behavior Nov 30, 2017
@chemelnucfin chemelnucfin added api: spanner Issues related to the Spanner API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Nov 30, 2017
@chemelnucfin chemelnucfin changed the title Spanner: Constructor bad behavior Spanner: Bad constructor behavior Nov 30, 2017
@chemelnucfin chemelnucfin force-pushed the spanner_ctor_bad branch 2 times, most recently from aa9582e to 008e5b0 Compare November 30, 2017 07:45
@chemelnucfin chemelnucfin reopened this Nov 30, 2017
@chemelnucfin
Copy link
Contributor Author

chemelnucfin commented Nov 30, 2017 •
edited
Loading

Something is wrong with this range stuff, I just haven't figured out how to fix it yet.

@chemelnucfin chemelnucfin changed the title Spanner: Bad constructor behavior WIP: Spanner: Bad constructor behavior Nov 30, 2017
@chemelnucfin
Copy link
Contributor Author

chemelnucfin commented Dec 4, 2017

See #4515

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lukesneeringer lukesneeringer Awaiting requested review from lukesneeringer

Assignees

No one assigned

Labels

api: spanner Issues related to the Spanner API. cla: yes This human has signed the Contributor License Agreement. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@chemelnucfin @googlebot