Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions spanner/google/cloud/spanner_v1/keyset.py
Original file line number Diff line number Diff line change
Expand Up @@ -41,10 +41,10 @@ def __init__(self, start_open=None, start_closed=None,
if not any([start_open, start_closed, end_open, end_closed]):
raise ValueError("Must specify at least a start or end row.")

if start_open and start_closed:
if start_open is not None and start_closed is not None:
raise ValueError("Specify one of 'start_open' / 'start_closed'.")

if end_open and end_closed:
if end_open is not None and end_closed is not None:
raise ValueError("Specify one of 'end_open' / 'end_closed'.")

self.start_open = start_open
Expand All @@ -60,17 +60,19 @@ def to_pb(self):
"""
kwargs = {}

if self.start_open:
if self.start_open is not None:
kwargs['start_open'] = _make_list_value_pb(self.start_open)

if self.start_closed:
elif self.start_closed is not None:

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

kwargs['start_closed'] = _make_list_value_pb(self.start_closed)
else:
kwargs['start_closed'] = _make_list_value_pb([])

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.


if self.end_open:
if self.end_open is not None:
kwargs['end_open'] = _make_list_value_pb(self.end_open)

if self.end_closed:
elif self.end_closed is not None:
kwargs['end_closed'] = _make_list_value_pb(self.end_closed)
else:
kwargs['end_closed'] = _make_list_value_pb([])

return KeyRangePB(**kwargs)

Expand Down
Loading