Allowed a custom Event type in Pub / Sub futures.
#4643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
dhermes
commented
Dec 20, 2017
| """ | ||
|
|
||
| # This could be a sentinel object or None, but the sentinel object's ID | ||
| # can change if the process is forked, and None has the possibility of | ||
| # actually being a result. | ||
| _SENTINEL = uuid.uuid4() | ||
|
|
||
| def __init__(self): | ||
| def __init__(self, event_factory=threading.Event): |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| """ | ||
| def __init__(self, policy): | ||
| def __init__(self, policy, *args, **kwargs): |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| @@ -263,7 +263,7 @@ def open(self, callback): | |||
| # Create the Future that this method will return. | |||
| # This future is the main thread's interface to handle exceptions, | |||
| # block on the subscription, etc. | |||
| self._future = Future(policy=self) | |||
| self._future = Future(policy=self, event_factory=threading.Event) | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
dhermes
force-pushed
the
pubsub-custom-event
branch
from
50d3abc to
1020c5e
Compare
dhermes
commented
Dec 21, 2017
| """ | ||
|
|
||
| # This could be a sentinel object or None, but the sentinel object's ID | ||
| # can change if the process is forked, and None has the possibility of | ||
| # actually being a result. | ||
| _SENTINEL = uuid.uuid4() | ||
|
|
||
| def __init__(self): | ||
| def __init__(self, completed=None): |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
lukesneeringer
approved these changes
Dec 21, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.