Guard setup with __name__ == '__main__' #4800
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chemelnucfin
requested review from
dhermes,
duggelz,
theacodes,
liyanhui1228,
lukesneeringer,
tseaver,
tswast and
waprin
as code owners
googlebot
added
the
cla: yes
chemelnucfin
force-pushed
the
issue4295-guard_setup
branch
from
4e3634a to
d5a94ad
Compare
|
We shouldn't do this
(Brevity because I'm traveling and such)
…On Sun, Jan 28, 2018, 7:40 PM chemelnucfin ***@***.***> wrote:
@chemelnucfin <https://github.com/chemelnucfin> requested your review on:
googleapis/google-cloud-python#4800
<#4800>
Guard setup with *name* == '*main*' as a code owner.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#4800 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAPUc-BJ1DcKp3buN1dgDeFQ2QiILPv4ks5tPT3AgaJpZM4RwBpb>
.
|
|
ok |
|
should I close #4295 also then? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial #4295
The other part is in toolkit/1828