-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Transaction dependency on Dataset. #494
Conversation
@@ -149,7 +149,7 @@ def mutation(self): | |||
(if one exists) or or a new mutation instance. | |||
""" | |||
if self.transaction(): | |||
return self.transaction().mutation() | |||
return self.transaction().mutation |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
||
return self._dataset | ||
|
||
@property |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Core changes LGTM. Some clashes (maybe) with #498? |
Yes, I'll wait until #498 is in and then rebase. |
#498 merged. |
Also - Making id(), connection() and mutation() getters on Transaction into @Property's. - Removing dataset() getter from Transaction.
Also - Fixed some unfound bugs due to disagreeing code and mocks. - Fixed test pollution of _implicit_environ namespace.
Changes Unknown when pulling cea9371 on dhermes:fix-486 into * on GoogleCloudPlatform:master*. |
Remove Transaction dependency on Dataset.
* Add client methods for Models API. * Adds hack to workaround milliseconds format for model.trainingRun.startTime. * Adds code samples for Models API, which double as system tests.
* chore: Update gapic-generator-python to v1.8.4 PiperOrigin-RevId: 507808936 Source-Link: googleapis/googleapis@64cf849 Source-Link: googleapis/googleapis-gen@53c48ca Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNTNjNDhjYWMxNTNkM2IzN2YzZDJjMmRlYzQ4MzBjZmQ5MWVjNDE1MyJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
* chore: Update gapic-generator-python to v1.8.4 PiperOrigin-RevId: 507808936 Source-Link: googleapis/googleapis@64cf849 Source-Link: googleapis/googleapis-gen@53c48ca Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNTNjNDhjYWMxNTNkM2IzN2YzZDJjMmRlYzQ4MzBjZmQ5MWVjNDE1MyJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
* chore: Update gapic-generator-python to v1.8.4 PiperOrigin-RevId: 507808936 Source-Link: googleapis/googleapis@64cf849 Source-Link: googleapis/googleapis-gen@53c48ca Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNTNjNDhjYWMxNTNkM2IzN2YzZDJjMmRlYzQ4MzBjZmQ5MWVjNDE1MyJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
* chore: Update gapic-generator-python to v1.8.4 PiperOrigin-RevId: 507808936 Source-Link: googleapis/googleapis@64cf849 Source-Link: googleapis/googleapis-gen@53c48ca Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNTNjNDhjYWMxNTNkM2IzN2YzZDJjMmRlYzQ4MzBjZmQ5MWVjNDE1MyJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
…494) Co-authored-by: Anthonios Partheniou <partheniou@google.com>
Source-Link: googleapis/synthtool@7ff4aad Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:462782b0b492346b2d9099aaff52206dd30bc8e031ea97082e6facecc2373244
…orts both formats (#494) * docs: Minor formatting chore: Update gapic-generator-python to v1.11.5 build: Update rules_python to 0.24.0 PiperOrigin-RevId: 563436317 Source-Link: googleapis/googleapis@42fd37b Source-Link: googleapis/googleapis-gen@280264c Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMjgwMjY0Y2EwMmZiOTMxNmI0MjM3YTk2ZDBhZjFhMjM0M2E4MWE1NiJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * docs: Update transferConfig.name description to indicate that it supports both formats PiperOrigin-RevId: 564447630 Source-Link: googleapis/googleapis@ca42ab6 Source-Link: googleapis/googleapis-gen@9433642 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiOTQzMzY0MjNmNDU1MjVkYjBiYTQzYjdlNGM3NWU1NWM2OWQ3YzZhMSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
🤖 I have created a release *beep* *boop* --- <details><summary>google-ai-generativelanguage: 0.3.4</summary> ## [0.3.4](google-ai-generativelanguage-v0.3.3...google-ai-generativelanguage-v0.3.4) (2023-09-30) ### Documentation * Minor formatting ([#11630](#11630)) ([b176996](b176996)) </details> <details><summary>google-apps-script-type: 0.3.4</summary> ## [0.3.4](google-apps-script-type-v0.3.3...google-apps-script-type-v0.3.4) (2023-09-30) ### Documentation * Minor formatting ([#11630](#11630)) ([b176996](b176996)) </details> <details><summary>google-area120-tables: 0.11.4</summary> ## [0.11.4](google-area120-tables-v0.11.3...google-area120-tables-v0.11.4) (2023-09-30) ### Documentation * Minor formatting ([#11630](#11630)) ([b176996](b176996)) </details> <details><summary>google-cloud-access-approval: 1.11.3</summary> ## [1.11.3](google-cloud-access-approval-v1.11.2...google-cloud-access-approval-v1.11.3) (2023-09-30) ### Documentation * Minor formatting ([#11630](#11630)) ([b176996](b176996)) </details> <details><summary>google-cloud-advisorynotifications: 0.3.1</summary> ## [0.3.1](google-cloud-advisorynotifications-v0.3.0...google-cloud-advisorynotifications-v0.3.1) (2023-09-30) ### Features * add new RPCs GetSettings, UpdateSettings and new messages Settings, NotificationSettings, GetSettingsRequest, UpdateSettingsRequest ([e395513](e395513)) </details> <details><summary>google-cloud-alloydb: 0.3.3</summary> ## [0.3.3](google-cloud-alloydb-v0.3.2...google-cloud-alloydb-v0.3.3) (2023-09-30) ### Features * Add support to generate client certificate and get connection info ([0f72d58](0f72d58)) * Add support to generate client certificate and get connection info for auth proxy in AlloyDB v1 ([#11764](#11764)) ([0f72d58](0f72d58)) </details> <details><summary>google-cloud-api-gateway: 1.7.3</summary> ## [1.7.3](google-cloud-api-gateway-v1.7.2...google-cloud-api-gateway-v1.7.3) (2023-09-30) ### Documentation * Minor formatting ([#11630](#11630)) ([b176996](b176996)) </details> <details><summary>google-cloud-api-keys: 0.5.4</summary> ## [0.5.4](google-cloud-api-keys-v0.5.3...google-cloud-api-keys-v0.5.4) (2023-09-30) ### Documentation * Minor formatting ([#11630](#11630)) ([b176996](b176996)) </details> <details><summary>google-cloud-apigee-connect: 1.7.3</summary> ## [1.7.3](google-cloud-apigee-connect-v1.7.2...google-cloud-apigee-connect-v1.7.3) (2023-09-30) ### Documentation * Minor formatting ([#11630](#11630)) ([b176996](b176996)) </details> <details><summary>google-cloud-apigee-registry: 0.6.4</summary> ## [0.6.4](google-cloud-apigee-registry-v0.6.3...google-cloud-apigee-registry-v0.6.4) (2023-09-30) ### Documentation * Minor formatting ([#11630](#11630)) ([b176996](b176996)) </details> <details><summary>google-cloud-appengine-logging: 1.3.2</summary> ## [1.3.2](google-cloud-appengine-logging-v1.3.1...google-cloud-appengine-logging-v1.3.2) (2023-09-30) ### Documentation * Minor formatting ([#11630](#11630)) ([b176996](b176996)) </details> <details><summary>google-cloud-artifact-registry: 1.8.4</summary> ## [1.8.4](google-cloud-artifact-registry-v1.8.3...google-cloud-artifact-registry-v1.8.4) (2023-09-30) ### Bug Fixes * make repository and repository_id in CreateRepository required ([3b8ea3e](3b8ea3e)) </details> <details><summary>google-cloud-bare-metal-solution: 1.5.1</summary> ## [1.5.1](google-cloud-bare-metal-solution-v1.5.0...google-cloud-bare-metal-solution-v1.5.1) (2023-09-30) ### Documentation * Minor formatting ([#11630](#11630)) ([b176996](b176996)) </details> <details><summary>google-cloud-batch: 0.17.1</summary> ## [0.17.1](google-cloud-batch-v0.17.0...google-cloud-batch-v0.17.1) (2023-09-30) ### Documentation * update batch PD interface support ([a300b07](a300b07)) </details> <details><summary>google-cloud-beyondcorp-appconnections: 0.4.4</summary> ## [0.4.4](google-cloud-beyondcorp-appconnections-v0.4.3...google-cloud-beyondcorp-appconnections-v0.4.4) (2023-09-30) ### Documentation * Minor formatting ([#11630](#11630)) ([b176996](b176996)) </details> <details><summary>google-cloud-beyondcorp-appconnectors: 0.4.4</summary> ## [0.4.4](google-cloud-beyondcorp-appconnectors-v0.4.3...google-cloud-beyondcorp-appconnectors-v0.4.4) (2023-09-30) ### Documentation * Minor formatting ([#11630](#11630)) ([b176996](b176996)) </details> <details><summary>google-cloud-beyondcorp-appgateways: 0.4.4</summary> ## [0.4.4](google-cloud-beyondcorp-appgateways-v0.4.3...google-cloud-beyondcorp-appgateways-v0.4.4) (2023-09-30) ### Documentation * Minor formatting ([#11630](#11630)) ([b176996](b176996)) </details> <details><summary>google-cloud-beyondcorp-clientconnectorservices: 0.4.4</summary> ## [0.4.4](google-cloud-beyondcorp-clientconnectorservices-v0.4.3...google-cloud-beyondcorp-clientconnectorservices-v0.4.4) (2023-09-30) ### Documentation * Minor formatting ([#11630](#11630)) ([b176996](b176996)) </details> <details><summary>google-cloud-beyondcorp-clientgateways: 0.4.3</summary> ## [0.4.3](google-cloud-beyondcorp-clientgateways-v0.4.2...google-cloud-beyondcorp-clientgateways-v0.4.3) (2023-09-30) ### Documentation * Minor formatting ([#11630](#11630)) ([b176996](b176996)) </details> <details><summary>google-cloud-bigquery-analyticshub: 0.4.3</summary> ## [0.4.3](google-cloud-bigquery-analyticshub-v0.4.2...google-cloud-bigquery-analyticshub-v0.4.3) (2023-09-30) ### Features * add Subscription resource and RPCs ([a18915b](a18915b)) </details> <details><summary>google-cloud-bigquery-connection: 1.13.2</summary> ## [1.13.2](google-cloud-bigquery-connection-v1.13.1...google-cloud-bigquery-connection-v1.13.2) (2023-09-30) ### Documentation * Minor formatting ([#342](#342)) ([cda2dc6](cda2dc6)) </details> <details><summary>google-cloud-bigquery-datatransfer: 3.12.1</summary> ## [3.12.1](google-cloud-bigquery-datatransfer-v3.12.0...google-cloud-bigquery-datatransfer-v3.12.1) (2023-09-30) ### Documentation * Update transferConfig.name description to indicate that it supports both formats ([#494](#494)) ([5141dc2](5141dc2)) </details> <details><summary>google-cloud-bigquery-reservation: 1.11.3</summary> ## [1.11.3](google-cloud-bigquery-reservation-v1.11.2...google-cloud-bigquery-reservation-v1.11.3) (2023-09-30) ### Documentation * Minor formatting ([#377](#377)) ([2b8616a](2b8616a)) </details> <details><summary>google-cloud-contact-center-insights: 1.13.0</summary> ## [1.13.0](google-cloud-contact-center-insights-v1.12.1...google-cloud-contact-center-insights-v1.13.0) (2023-09-30) ### Features * add optional SpeechConfig to UploadConversationRequest ([bfc25b7](bfc25b7)) </details> <details><summary>google-cloud-container: 2.32.0</summary> ## [2.32.0](google-cloud-container-v2.31.0...google-cloud-container-v2.32.0) (2023-09-30) ### Features * add SecurityPostureConfig Enterprise vuln mode to allow customers to enable Advanced Vulnerability Scanning for their clusters ([#413](#413)) ([0280a30](0280a30)) ### Documentation * Minor formatting ([#411](#411)) ([1408937](1408937)) </details> <details><summary>google-cloud-contentwarehouse: 0.7.2</summary> ## [0.7.2](google-cloud-contentwarehouse-v0.7.1...google-cloud-contentwarehouse-v0.7.2) (2023-09-30) ### Features * add matched_token_page_indices field in Document Warehouse API v1 ([030a767](030a767)) </details> <details><summary>google-cloud-datacatalog: 3.16.0</summary> ## [3.16.0](google-cloud-datacatalog-v3.15.2...google-cloud-datacatalog-v3.16.0) (2023-09-30) ### Features * Enable Vertex AI Ingestion on DataPlex ([#11762](#11762)) ([b9d7b71](b9d7b71)) </details> <details><summary>google-cloud-dataproc-metastore: 1.13.0</summary> ## [1.13.0](google-cloud-dataproc-metastore-v1.12.1...google-cloud-dataproc-metastore-v1.13.0) (2023-09-30) ### Features * added EndpointLocation (v1, v1beta, v1alpha) ([b254665](b254665)) </details> <details><summary>google-cloud-dialogflow: 2.25.0</summary> ## [2.25.0](google-cloud-dialogflow-v2.24.1...google-cloud-dialogflow-v2.25.0) (2023-09-30) ### Features * Add the enable_partial_automated_agent_reply flag ([2996e9b](2996e9b)) * Remove backend API deadline ([2996e9b](2996e9b)) </details> <details><summary>google-cloud-dialogflow-cx: 1.28.0</summary> ## [1.28.0](google-cloud-dialogflow-cx-v1.27.1...google-cloud-dialogflow-cx-v1.28.0) (2023-09-30) ### Features * add Inline destination ([40ee037](40ee037)) * add Intent import/export APIs ([40ee037](40ee037)) * add support for AdvancedSettings ([40ee037](40ee037)) </details> <details><summary>google-cloud-network-connectivity: 2.2.0</summary> ## [2.2.0](google-cloud-network-connectivity-v2.1.0...google-cloud-network-connectivity-v2.2.0) (2023-09-30) ### Features * add Network Connectivity Center APIs related to VPC spokes ([#11769](#11769)) ([4cf708c](4cf708c)) </details> <details><summary>google-cloud-os-config: 1.15.3</summary> ## [1.15.3](google-cloud-os-config-v1.15.2...google-cloud-os-config-v1.15.3) (2023-09-30) ### Documentation * Minor formatting ([#295](#295)) ([8805a43](8805a43)) </details> <details><summary>google-cloud-scheduler: 2.11.2</summary> ## [2.11.2](google-cloud-scheduler-v2.11.1...google-cloud-scheduler-v2.11.2) (2023-09-30) ### Documentation * Minor formatting ([#353](#353)) ([951433b](951433b)) </details> <details><summary>google-cloud-texttospeech: 2.14.2</summary> ## [2.14.2](google-cloud-texttospeech-v2.14.1...google-cloud-texttospeech-v2.14.2) (2023-09-30) ### Documentation * Minor formatting ([#388](#388)) ([c051f1b](c051f1b)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Source-Link: googleapis/synthtool@50db768 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:e09366bdf0fd9c8976592988390b24d53583dd9f002d476934da43725adbb978
Source-Link: googleapis/synthtool@50db768 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:e09366bdf0fd9c8976592988390b24d53583dd9f002d476934da43725adbb978
Source-Link: googleapis/synthtool@909573c Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:ddf4551385d566771dc713090feb7b4c1164fb8a698fe52bbe7670b24236565b Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
* fix(deps): allow protobuf 3.19.5 * explicitly exclude protobuf 4.21.0
* chore: Update gapic-generator-python to v1.11.4 PiperOrigin-RevId: 547897126 Source-Link: googleapis/googleapis@c09c75e Source-Link: googleapis/googleapis-gen@45e0ec4 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNDVlMGVjNDM0MzUxN2NkMGFhNjZiNWNhNjQyMzJhMTgwMmMyZjk0NSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
* chore: Update gapic-generator-python to v1.8.4 PiperOrigin-RevId: 507808936 Source-Link: googleapis/googleapis@64cf849 Source-Link: googleapis/googleapis-gen@53c48ca Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNTNjNDhjYWMxNTNkM2IzN2YzZDJjMmRlYzQ4MzBjZmQ5MWVjNDE1MyJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Fixes #486.