Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Test runs for Python 3.7 and remove 3.4 #5295

Merged
merged 3 commits into from
May 4, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion api_core/nox.py
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ def default(session):


@nox.session
@nox.parametrize('py', ['2.7', '3.4', '3.5', '3.6'])
@nox.parametrize('py', ['2.7', '3.5', '3.6', '3.7'])
def unit(session, py):
"""Run the unit test suite."""

Expand Down
2 changes: 1 addition & 1 deletion bigquery/nox.py
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ def default(session):


@nox.session
@nox.parametrize('py', ['2.7', '3.4', '3.5', '3.6'])
@nox.parametrize('py', ['2.7', '3.5', '3.6'])
def unit(session, py):
"""Run the unit test suite."""

Expand Down
2 changes: 1 addition & 1 deletion bigquery_datatransfer/nox.py
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ def default(session):


@nox.session
@nox.parametrize('py', ['2.7', '3.4', '3.5', '3.6'])
@nox.parametrize('py', ['2.7', '3.5', '3.6', '3.7'])
def unit(session, py):
"""Run the unit test suite."""

Expand Down
2 changes: 1 addition & 1 deletion bigtable/nox.py
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ def default(session):


@nox.session
@nox.parametrize('py', ['2.7', '3.4', '3.5', '3.6'])
@nox.parametrize('py', ['2.7', '3.5', '3.6', '3.7'])
def unit(session, py):
"""Run the unit test suite."""

Expand Down
2 changes: 1 addition & 1 deletion container/nox.py
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ def default(session):


@nox.session
@nox.parametrize('py', ['2.7', '3.4', '3.5', '3.6'])
@nox.parametrize('py', ['2.7', '3.5', '3.6', '3.7'])
def unit(session, py):
"""Run the unit test suite."""

Expand Down
2 changes: 1 addition & 1 deletion core/nox.py
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ def default(session):


@nox.session
@nox.parametrize('py', ['2.7', '3.4', '3.5', '3.6'])
@nox.parametrize('py', ['2.7', '3.5', '3.6', '3.7'])
def unit(session, py):
"""Run the unit test suite."""

Expand Down
2 changes: 1 addition & 1 deletion dataproc/nox.py
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ def default(session):


@nox.session
@nox.parametrize('py', ['2.7', '3.4', '3.5', '3.6'])
@nox.parametrize('py', ['2.7', '3.5', '3.6', '3.7'])
def unit(session, py):
"""Run the unit test suite."""

Expand Down
2 changes: 1 addition & 1 deletion datastore/nox.py
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ def default(session):


@nox.session
@nox.parametrize('py', ['2.7', '3.4', '3.5', '3.6'])
@nox.parametrize('py', ['2.7', '3.5', '3.6', '3.7'])
def unit(session, py):
"""Run the unit test suite."""

Expand Down
2 changes: 1 addition & 1 deletion dlp/nox.py
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ def default(session):


@nox.session
@nox.parametrize('py', ['2.7', '3.4', '3.5', '3.6'])
@nox.parametrize('py', ['2.7', '3.5', '3.6', '3.7'])
def unit(session, py):
"""Run the unit test suite."""

Expand Down
2 changes: 1 addition & 1 deletion dns/nox.py
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ def default(session):


@nox.session
@nox.parametrize('py', ['2.7', '3.4', '3.5', '3.6'])
@nox.parametrize('py', ['2.7', '3.5', '3.6', '3.7'])
def unit(session, py):
"""Run the unit test suite."""

Expand Down
2 changes: 1 addition & 1 deletion error_reporting/nox.py
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ def default(session):


@nox.session
@nox.parametrize('py', ['2.7', '3.4', '3.5', '3.6'])
@nox.parametrize('py', ['2.7', '3.5', '3.6', '3.7'])
def unit(session, py):
"""Run the unit test suite."""

Expand Down
2 changes: 1 addition & 1 deletion firestore/nox.py
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ def default(session):


@nox.session
@nox.parametrize('py', ['2.7', '3.4', '3.5', '3.6'])
@nox.parametrize('py', ['2.7', '3.5', '3.6', '3.7'])
def unit(session, py):
"""Run the unit test suite."""

Expand Down
2 changes: 1 addition & 1 deletion language/nox.py
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ def default(session):


@nox.session
@nox.parametrize('py', ['2.7', '3.4', '3.5', '3.6'])
@nox.parametrize('py', ['2.7', '3.5', '3.6', '3.7'])
def unit(session, py):
"""Run the unit test suite."""

Expand Down
2 changes: 1 addition & 1 deletion logging/nox.py
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ def default(session):


@nox.session
@nox.parametrize('py', ['2.7', '3.4', '3.5', '3.6'])
@nox.parametrize('py', ['2.7', '3.5', '3.6', '3.7'])
def unit(session, py):
"""Run the unit test suite."""

Expand Down
2 changes: 1 addition & 1 deletion monitoring/nox.py
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ def default(session):


@nox.session
@nox.parametrize('py', ['2.7', '3.4', '3.5', '3.6'])
@nox.parametrize('py', ['2.7', '3.5', '3.6'])
def unit(session, py):
"""Run the unit test suite."""

Expand Down
2 changes: 1 addition & 1 deletion oslogin/nox.py
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ def default(session):


@nox.session
@nox.parametrize('py', ['2.7', '3.4', '3.5', '3.6'])
@nox.parametrize('py', ['2.7', '3.5', '3.6', '3.7'])
def unit(session, py):
"""Run the unit test suite."""

Expand Down
6 changes: 5 additions & 1 deletion pubsub/google/cloud/pubsub_v1/subscriber/scheduler.py
Original file line number Diff line number Diff line change
Expand Up @@ -118,5 +118,9 @@ def shutdown(self):
# Drop all pending item from the executor. Without this, the executor
# will block until all pending items are complete, which is
# undesirable.
self._executor._work_queue.queue.clear()
try:
while True:
self._executor._work_queue.get(block=False)
except queue.Empty:
pass
self._executor.shutdown()
2 changes: 1 addition & 1 deletion pubsub/nox.py
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ def default(session):


@nox.session
@nox.parametrize('py', ['2.7', '3.4', '3.5', '3.6'])
@nox.parametrize('py', ['2.7', '3.5', '3.6', '3.7'])
def unit(session, py):
"""Run the unit test suite."""

Expand Down
2 changes: 1 addition & 1 deletion resource_manager/nox.py
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ def default(session):


@nox.session
@nox.parametrize('py', ['2.7', '3.4', '3.5', '3.6'])
@nox.parametrize('py', ['2.7', '3.5', '3.6', '3.7'])
def unit(session, py):
"""Run the unit test suite."""

Expand Down
2 changes: 1 addition & 1 deletion runtimeconfig/nox.py
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ def default(session):


@nox.session
@nox.parametrize('py', ['2.7', '3.4', '3.5', '3.6'])
@nox.parametrize('py', ['2.7', '3.5', '3.6', '3.7'])
def unit(session, py):
"""Run the unit test suite."""

Expand Down
2 changes: 1 addition & 1 deletion speech/nox.py
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ def default(session):


@nox.session
@nox.parametrize('py', ['2.7', '3.4', '3.5', '3.6'])
@nox.parametrize('py', ['2.7', '3.5', '3.6', '3.7'])
def unit(session, py):
"""Run the unit test suite."""

Expand Down
2 changes: 1 addition & 1 deletion storage/nox.py
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ def default(session):


@nox.session
@nox.parametrize('py', ['2.7', '3.4', '3.5', '3.6'])
@nox.parametrize('py', ['2.7', '3.5', '3.6', '3.7'])
def unit(session, py):
"""Run the unit test suite."""

Expand Down
2 changes: 1 addition & 1 deletion texttospeech/nox.py
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ def default(session):


@nox.session
@nox.parametrize('py', ['2.7', '3.4', '3.5', '3.6'])
@nox.parametrize('py', ['2.7', '3.5', '3.6', '3.7'])
def unit(session, py):
"""Run the unit test suite."""

Expand Down
2 changes: 1 addition & 1 deletion trace/nox.py
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ def default(session):


@nox.session
@nox.parametrize('py', ['2.7', '3.4', '3.5', '3.6'])
@nox.parametrize('py', ['2.7', '3.5', '3.6', '3.7'])
def unit(session, py):
"""Run the unit test suite."""

Expand Down
2 changes: 1 addition & 1 deletion translate/nox.py
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ def default(session):


@nox.session
@nox.parametrize('py', ['2.7', '3.4', '3.5', '3.6'])
@nox.parametrize('py', ['2.7', '3.5', '3.6', '3.7'])
def unit(session, py):
"""Run the unit test suite."""

Expand Down
2 changes: 1 addition & 1 deletion videointelligence/nox.py
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ def default(session):


@nox.session
@nox.parametrize('py', ['2.7', '3.4', '3.5', '3.6'])
@nox.parametrize('py', ['2.7', '3.5', '3.6', '3.7'])
def unit(session, py):
"""Run the unit test suite."""

Expand Down
2 changes: 1 addition & 1 deletion vision/nox.py
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ def default(session):


@nox.session
@nox.parametrize('py', ['2.7', '3.4', '3.5', '3.6'])
@nox.parametrize('py', ['2.7', '3.5', '3.6', '3.7'])
def unit(session, py):
"""Run the unit test suite."""

Expand Down
2 changes: 1 addition & 1 deletion websecurityscanner/nox.py
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ def default(session):


@nox.session
@nox.parametrize('py', ['2.7', '3.4', '3.5', '3.6'])
@nox.parametrize('py', ['2.7', '3.5', '3.6', '3.7'])
def unit(session, py):
"""Run the unit test suite."""

Expand Down