Skip to content

Fix regression in 'Transaction.rollback()' #556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tseaver merged 1 commit into from
Jan 15, 2015
Merged

Fix regression in 'Transaction.rollback()' #556

tseaver merged 1 commit into from
Jan 15, 2015

Conversation

@tseaver
Copy link
Contributor

@tseaver tseaver commented Jan 15, 2015

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 15, 2015
@coveralls
Copy link

coveralls commented Jan 15, 2015

Coverage Status

Coverage remained the same when pulling e1d52a8 on tseaver:fix-transaction_rollback_regression into 55285f9 on GoogleCloudPlatform:master.

@tseaver
Copy link
Contributor Author

tseaver commented Jan 15, 2015

@dhermes PTAL: I'm not sure why we weren't seeing regression failures on Travis without this fix.

@tseaver tseaver added do not merge Indicates a pull request not ready for merge, due to either quality or timing. and removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Jan 15, 2015
@dhermes
Copy link
Contributor

dhermes commented Jan 15, 2015

LGTM. I don't think rollback is called in regression tests unless something fails

tseaver added a commit that referenced this pull request Jan 15, 2015
@tseaver
Merge pull request #556 from tseaver/fix-transaction_rollback_regression
d17100e 
Fix regression in 'Transaction.rollback()'
@tseaver tseaver merged commit d17100e into googleapis:master Jan 15, 2015
@tseaver tseaver deleted the fix-transaction_rollback_regression branch January 15, 2015 19:20
vchudnov-g pushed a commit that referenced this pull request Sep 20, 2023
@gcf-owl-bot
chore: use gapic-generator-python 1.2.0 (#556)
a23e68d 
* chore: use gapic-generator-python 1.2.0

PiperOrigin-RevId: 467286830

Source-Link: googleapis/googleapis@e6e875a

Source-Link: googleapis/googleapis-gen@0295ea1
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMDI5NWVhMTRkOWNkNGQ0N2RkYjIzYjllYmQzOWEzMWUyMDM1ZTI4ZiJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Sep 22, 2023
@release-please
chore(main): release 5.5.0 (#556)
8088e43 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Oct 21, 2023
@gcf-owl-bot
chore: [autoapprove] Pin flake8 version (#556)
377428d 
Source-Link: googleapis/synthtool@0ddbff8
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:bced5ca77c4dda0fd2f5d845d4035fc3c5d3d6b81f245246a36aee114970082b

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Oct 21, 2023
@gcf-owl-bot
chore: [autoapprove] bump cryptography from 41.0.3 to 41.0.4 (#556)
f2bc694 
Source-Link: googleapis/synthtool@dede53f
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:fac304457974bb530cc5396abd4ab25d26a469cd3bc97cbfb18c8d4324c584eb

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Aug 21, 2025
@renovate-bot
chore(deps): update dependency google-cloud-bigquery-storage to v2.18…
d44b2ef 
….1 (#556)
parthea pushed a commit that referenced this pull request Sep 16, 2025
@renovate-bot @parthea
chore(deps): update dependency google-cloud-bigquery-storage to v2.18…
7ff7daf 
….1 (#556)
parthea pushed a commit that referenced this pull request Nov 24, 2025
@gcf-owl-bot @daniel-sanche
chore(python): fix docs build (#556)
985c8ae 
Source-Link: googleapis/synthtool@bef813d
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:94bb690db96e6242b2567a4860a94d48fa48696d092e51b0884a1a2c0a79a407

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Daniel Sanche <sanche@google.com>
parthea added a commit that referenced this pull request Nov 24, 2025
@parthea
chore: remove unused files (#556)
6c5b6a9 
* chore: remove unused files

* remove post processing for .kokoro/docs
parthea pushed a commit that referenced this pull request Nov 24, 2025
@gcf-owl-bot
chore(python): Enable size-label bot (#556)
181b2fb 
Source-Link: googleapis/synthtool@06e8279
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:b3500c053313dc34e07b1632ba9e4e589f4f77036a7cf39e1fe8906811ae0fce
parthea pushed a commit that referenced this pull request Nov 24, 2025
fix: fix a connection leak in RedisCache (#556)
2ac210d
parthea pushed a commit that referenced this pull request Nov 26, 2025
@yoshi-automation
chore: update kokoro config (via synth) (#556)
048a907 
This PR was generated using Autosynth. 🌈

Synth log will be available here:
https://source.cloud.google.com/results/invocations/abd11f9f-00ea-4883-9679-79e339a91948/targets

- [ ] To automatically regenerate this PR, check this box.

Source-Link: googleapis/synthtool@ffe1040
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tseaver @coveralls @dhermes @googlebot