Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix '_time_from_iso8601_time_naive' for values with micros. #5756

Merged
merged 1 commit into from
Aug 6, 2018
Merged

Fix '_time_from_iso8601_time_naive' for values with micros. #5756

merged 1 commit into from
Aug 6, 2018

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Aug 6, 2018

Closes #5750.

@tseaver tseaver requested a review from mcdonc August 6, 2018 17:46
@tseaver tseaver requested a review from theacodes as a code owner August 6, 2018 17:46
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 6, 2018
Copy link
Contributor

@mcdonc mcdonc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor question.

"""
return datetime.datetime.strptime(value, '%H:%M:%S').time()
if len(value) == 8: # HH:MM:SS

This comment was marked as spam.

This comment was marked as spam.

@tseaver tseaver merged commit 06e860a into googleapis:master Aug 6, 2018
@tseaver tseaver deleted the 5750-core-fix-_time_from_is08601_time_naive-subsec branch August 6, 2018 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: core cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants