Generate Redis v1 with new redis/synth.py #5945

danoscarmike · 2018-09-12T06:17:13Z

No description provided.

redis/nox.py

-    os.path.join('..', 'core'),
-)
-
-


redis/nox.py

-    session.interpreter = 'python3.6'
-    session.install('coverage', 'pytest-cov')
-    session.run('coverage', 'report', '--show-missing', '--fail-under=100')
-    session.run('coverage', 'erase')


redis/setup.py

 name = 'google-cloud-redis'
-description = 'Cloud Redis API client library'
+description = 'Google Cloud Memorystore for Redis API API client library'


redis/setup.py

-# Should be one of:
-# 'Development Status :: 3 - Alpha'
-# 'Development Status :: 4 - Beta'
-# 'Development Status :: 5 - Production/Stable'


redis/setup.py


 package_root = os.path.abspath(os.path.dirname(__file__))

 readme_filename = os.path.join(package_root, 'README.rst')
 with io.open(readme_filename, encoding='utf-8') as readme_file:
    readme = readme_file.read()

-# Only include packages under the 'google' namespace. Do not include tests,
-# benchmarks, etc.


redis/setup.py

-    'google-api-core[grpc] >= 0.1.0, < 0.2.0dev',
+    'google-api-core[grpc] >= 1.1.0, < 2.0.0dev',
+    'enum34; python_version < "3.4"',
+    'grpc-google-iam-v1<0.12dev,>=0.11.4',


tseaver · 2018-09-12T06:33:22Z

I wonder if we need an option for synthtool to leave anything outside of gapic and proto alone: I'm not confident that trying to fix it up with synth.py afterwards is sufficient to risk damaging the library.

theacodes · 2018-09-12T16:28:43Z

I wonder if we need an option for synthtool to leave anything outside of gapic and proto alone: I'm not confident that trying to fix it up with synth.py afterwards is sufficient to risk damaging the library.

Yep, we have the ability to copy just subdirs and exclude specific files as well. Check out pubsub's synth.py. Also, you can take a look at the source for synthtool over here: https://github.com/GoogleCloudPlatform/synthtool

googlebot · 2018-09-12T17:48:23Z

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

danoscarmike · 2018-09-12T19:50:52Z

Thanks @tseaver for jumping on these fixes. Much appreciated.

@theacodes are we good to merge and release this? Can you override the cla label?

googlebot · 2018-09-12T22:03:09Z

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

theacodes · 2018-09-12T22:03:52Z

Circle is still failing due to bad docstrings (uggg). @tseaver do you mind adding the appropriate replaces in synth.py to work around those?

danoscarmike · 2018-09-13T22:26:01Z

@tseaver @theacodes apologies for lobbing the 💣 and running. I'm happy to continue to work on this but will need some direction...

Unfortunately we are on the clock with this one and need to get it released ASAP.

theacodes · 2018-09-13T22:44:40Z

@tseaver can you take over?

…

On Thu, Sep 13, 2018, 3:26 PM danoscarmike ***@***.***> wrote: @tseaver <https://github.com/tseaver> @theacodes <https://github.com/theacodes> apologies for lobbing the 💣 and running. I'm happy to continue to work on this but will need some direction... Unfortunately we are on the clock with this one and need to get it released ASAP. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#5945 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAPUc6mMWWnUcbFCGXovZMtsAEZc4FqRks5uatt6gaJpZM4WktuN> .

theacodes · 2018-09-14T18:15:06Z

Nvm, I got it, eta ~1 hour or so.

googlebot · 2018-09-14T19:40:42Z

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

googlebot · 2018-09-14T19:40:58Z

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

Update 'synth.py' to avoid munging it again.

googlebot · 2018-09-14T19:50:49Z

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

googlebot · 2018-09-14T19:52:37Z

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

danoscarmike requested a review from theacodes September 12, 2018 06:17

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 12, 2018

tseaver suggested changes Sep 12, 2018

View reviewed changes

tseaver force-pushed the dan_redis branch from 3cd49cf to 4a1722b Compare September 12, 2018 17:48

googlebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Sep 12, 2018

tseaver approved these changes Sep 12, 2018

View reviewed changes

theacodes added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Sep 12, 2018

googlebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Sep 14, 2018

theacodes added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Sep 14, 2018

danoscarmike and others added 6 commits September 14, 2018 12:50

add redis/synth.py, gen redis_v1

dad68aa

clean up synth.py

90cd17a

add s.replace rules, regen README

13125f3

add trailing '/' to links

fd5ea7d

Undo undesirable changes in 'nox.py'.

4173023

Update 'synth.py' to avoid munging it again.

Undo undesirable changes in 'setup.py'.

65fd1a7

Update 'synth.py' to avoid munging it again.

tseaver and others added 2 commits September 14, 2018 12:50

google.iam is not used in this library.

3c61e99

Fixup docstrings

e1a9b74

theacodes force-pushed the dan_redis branch from 25884f6 to e1a9b74 Compare September 14, 2018 19:50

googlebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Sep 14, 2018

theacodes added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Sep 14, 2018

theacodes merged commit b262661 into master Sep 14, 2018

theacodes deleted the dan_redis branch September 14, 2018 20:00

tseaver added codegen api: redis Issues related to the Memorystore for Redis API. and removed api: redis Issues related to the Memorystore for Redis API. labels Sep 17, 2018

parthea pushed a commit that referenced this pull request Jun 4, 2023

Generate Redis v1 with new redis/synth.py (#5945)

5f72e54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Generate Redis v1 with new redis/synth.py #5945

Generate Redis v1 with new redis/synth.py #5945

danoscarmike commented Sep 12, 2018

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

tseaver commented Sep 12, 2018

theacodes commented Sep 12, 2018

googlebot commented Sep 12, 2018

danoscarmike commented Sep 12, 2018

googlebot commented Sep 12, 2018

theacodes commented Sep 12, 2018

danoscarmike commented Sep 13, 2018

theacodes commented Sep 13, 2018 via email

theacodes commented Sep 14, 2018

googlebot commented Sep 14, 2018

googlebot commented Sep 14, 2018

googlebot commented Sep 14, 2018

googlebot commented Sep 14, 2018

Generate Redis v1 with new redis/synth.py #5945

Generate Redis v1 with new redis/synth.py #5945

Conversation

danoscarmike commented Sep 12, 2018

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

tseaver commented Sep 12, 2018

theacodes commented Sep 12, 2018

googlebot commented Sep 12, 2018

danoscarmike commented Sep 12, 2018

googlebot commented Sep 12, 2018

theacodes commented Sep 12, 2018

danoscarmike commented Sep 13, 2018

theacodes commented Sep 13, 2018 via email

theacodes commented Sep 14, 2018

googlebot commented Sep 14, 2018

googlebot commented Sep 14, 2018

googlebot commented Sep 14, 2018

googlebot commented Sep 14, 2018