-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding ability to give default QueryJobConfig to Client #6088
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
CLAs look good, thanks! |
Making a PR from your WRT the test failures, there is missing line / branch coverage for:
which is the case where no |
@tseaver Sorry about not creating a feature branch ha, I don't expect to maintain a fork for a long period, I was just hoping to include this feature, but I shouldn't have cut corners. |
@@ -1187,7 +1189,9 @@ def extract_table( | |||
return extract_job | |||
|
|||
def query( | |||
self, query, job_config=None, job_id=None, job_id_prefix=None, | |||
self, query, | |||
job_config=None, override_job_config=False, |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, thanks! Just a few comments. I'm not convinced we need the merge_job_config
argument yet.
Also, update the docstrings to Google/Napoleon-style.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love it! Thank you so much for your contribution, @blainehansen.
FYI: I've made fill_from_default "private" by prefixing an underscore, because I don't think it's necessary to add this method to the public API interface. (It's fine to use from other modules within this library.)
@tseaver Please take a look.
👍 yeah making that private is definitely a better choice 😄 |
🎊 🎊 🎊 Thanks everyone! |
closes #5183
This isn't a complete request (I need to do things like fill out the Contributor License Agreements, get coverage all the way to 100%, etc), but I wanted to begin the discussion to see if this was an acceptable direction. Only QueryJobConfig has been implemented, but the other types shouldn't be too difficult, since I've added a
_JobConfig.fill_from_default
method.