Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BigQuery: harden snippets against transient GCS errors. #6184

Merged
merged 1 commit into from
Oct 10, 2018
Merged

BigQuery: harden snippets against transient GCS errors. #6184

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 13 additions & 12 deletions bigquery/docs/snippets.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,11 @@
pyarrow = None

from google.api_core import datetime_helpers
from google.api_core.exceptions import InternalServerError
from google.api_core.exceptions import ServiceUnavailable
from google.api_core.exceptions import TooManyRequests
from google.cloud import bigquery
from google.cloud import storage
from test_utils.retry import RetryErrors

ORIGINAL_FRIENDLY_NAME = 'Original friendly name'
Expand Down Expand Up @@ -68,6 +71,8 @@


retry_429 = RetryErrors(TooManyRequests)
retry_storage_errors = RetryErrors(
(TooManyRequests, InternalServerError, ServiceUnavailable))


@pytest.fixture(scope='module')
Expand All @@ -82,6 +87,8 @@ def to_delete(client):
for item in doomed:
if isinstance(item, (bigquery.Dataset, bigquery.DatasetReference)):
retry_429(client.delete_dataset)(item, delete_contents=True)
elif isinstance(item, storage.Bucket):
retry_storage_errors(item.delete)()
else:
retry_429(item.delete)()

Expand Down Expand Up @@ -1880,11 +1887,9 @@ def test_copy_table_cmek(client, to_delete):


def test_extract_table(client, to_delete):
from google.cloud import storage

bucket_name = 'extract_shakespeare_{}'.format(_millis())
storage_client = storage.Client()
bucket = retry_429(storage_client.create_bucket)(bucket_name)
bucket = retry_storage_errors(storage_client.create_bucket)(bucket_name)
to_delete.append(bucket)

# [START bigquery_extract_table]
Expand All @@ -1910,18 +1915,16 @@ def test_extract_table(client, to_delete):
project, dataset_id, table_id, destination_uri))
# [END bigquery_extract_table]

blob = bucket.get_blob('shakespeare.csv')
blob = retry_storage_errors(bucket.get_blob)('shakespeare.csv')
assert blob.exists
assert blob.size > 0
to_delete.insert(0, blob)


def test_extract_table_json(client, to_delete):
from google.cloud import storage

bucket_name = 'extract_shakespeare_json_{}'.format(_millis())
storage_client = storage.Client()
bucket = retry_429(storage_client.create_bucket)(bucket_name)
bucket = retry_storage_errors(storage_client.create_bucket)(bucket_name)
to_delete.append(bucket)

# [START bigquery_extract_table_json]
Expand All @@ -1945,18 +1948,16 @@ def test_extract_table_json(client, to_delete):
extract_job.result() # Waits for job to complete.
# [END bigquery_extract_table_json]

blob = bucket.get_blob('shakespeare.json')
blob = retry_storage_errors(bucket.get_blob)('shakespeare.json')
assert blob.exists
assert blob.size > 0
to_delete.insert(0, blob)


def test_extract_table_compressed(client, to_delete):
from google.cloud import storage

bucket_name = 'extract_shakespeare_compress_{}'.format(_millis())
storage_client = storage.Client()
bucket = retry_429(storage_client.create_bucket)(bucket_name)
bucket = retry_storage_errors(storage_client.create_bucket)(bucket_name)
to_delete.append(bucket)

# [START bigquery_extract_table_compressed]
Expand All @@ -1979,7 +1980,7 @@ def test_extract_table_compressed(client, to_delete):
extract_job.result() # Waits for job to complete.
# [END bigquery_extract_table_compressed]

blob = bucket.get_blob('shakespeare.csv.gz')
blob = retry_storage_errors(bucket.get_blob)('shakespeare.csv.gz')
assert blob.exists
assert blob.size > 0
to_delete.insert(0, blob)
Expand Down