-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BigQuery: add 'retry' argument to '_AsyncJob.result'. #6302
BigQuery: add 'retry' argument to '_AsyncJob.result'. #6302
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, though I'll want to hear what Chris or Thea thinks since this is a divergence from the standard "futures" interface. Maybe we should store a private Retry object on the Job class instead? We already override done() for some of the job types.
@tswast The |
I had actually planned to update the |
If we close this PR without merging (i.e., we decide not to add a |
Depends The If we decide not to expose it, then I think we still need to pass the from google.cloud.bigquery import job
...
copy_job = job.CopyJob(
job_ref, sources, destination, client=client, job_config=job_config)
copy_job._retry = copy_job._retry.with_deadline(600)
result = copy_job.result() |
Pass it through to the '_begin' call. Note that we need to modify the 'api_core...PollingFuture' class before we can safely pass the 'retry' through to its 'result'.
Rebased to work around borked CI runs for irrelevant APIs. |
Pass it through to the
_begin
call. Note that we need to modifythe
api_core...PollingFuture
class before we can safely pass theretry
through to itsresult
.