Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release logging 1.9.0 #6893

Merged
merged 3 commits into from
Dec 10, 2018
Merged

Release logging 1.9.0 #6893

merged 3 commits into from
Dec 10, 2018

Conversation

crwilcox
Copy link
Contributor

This pull request was generated using releasetool.

@crwilcox crwilcox requested a review from tseaver as a code owner December 10, 2018 20:58
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 10, 2018
@crwilcox crwilcox mentioned this pull request Dec 10, 2018
Closed
tseaver
tseaver suggested changes Dec 10, 2018
View reviewed changes
logging/CHANGELOG.md Outdated Show resolved Hide resolved
@tseaver @crwilcox
Update logging/CHANGELOG.md
c0ad46f 
Co-Authored-By: crwilcox <crwilcox@google.com>
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

@googlebot googlebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Dec 10, 2018
@crwilcox crwilcox added the cla: yes This human has signed the Contributor License Agreement. label Dec 10, 2018
@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

@googlebot googlebot removed the cla: no This human has *not* signed the Contributor License Agreement. label Dec 10, 2018
@crwilcox crwilcox merged commit 0e73f5c into master Dec 10, 2018
@crwilcox
Copy link
Contributor Author

Release is at https://github.com/googleapis/google-cloud-python/releases/tag/logging-1.9.0

@crwilcox crwilcox deleted the release-logging-1.9.0 branch December 10, 2018 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tseaver tseaver tseaver approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@crwilcox @googlebot @tseaver