Fixing demo runner: used to print empty newline at beginning of demo. #719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
|
LGTM |
|
I'm gonna hold off on merging until I hear from @jgeewax about the license |
| @@ -1,16 +1,3 @@ | |||
| # Copyright 2014 Google Inc. All rights reserved. | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
They are really alternative solutions to the same problem. @jgeewax, which do you prefer? |
Also putting license below the fold (adding back to storage demo). This is so that the user sees the message "You don't need to do anything, just keep hitting enter..." is printed first.
dhermes
force-pushed
the
fix-demo-runner
branch
from
4a99f8f to
f4240a4
Compare
|
@dhermes go ahead with your solution here. |
dhermes
added a commit
that referenced
this pull request
Mar 24, 2015
Fixing demo runner: used to print empty newline at beginning of demo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also removing license from datastore demo.Also putting license below the fold (adding back to storage demo). This is so that the user sees the message
printed first.
@jgeewax Is it OK to remove the license from the
demo.pyfiles? Without the opening line (in the demo) of:# Welcome to the gCloud Storage Demo! (hit enter)it is unclear what to do next (e.g. if it starts with a giant glob of license text).
See my previous comment for some context.