Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add args from RowIterator.to_dataframe() to QueryJob.to_dataframe() #7241

Merged
merged 2 commits into from
Feb 1, 2019
Merged

Add args from RowIterator.to_dataframe() to QueryJob.to_dataframe() #7241

merged 2 commits into from
Feb 1, 2019

Conversation

tswast
Copy link
Contributor

@tswast tswast commented Jan 31, 2019

No description provided.

@tswast tswast added the api: bigquery Issues related to the BigQuery API. label Jan 31, 2019
@tswast tswast requested review from shollyman and alixhami January 31, 2019 01:39
@tswast tswast requested a review from crwilcox as a code owner January 31, 2019 01:39
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 31, 2019
tseaver
tseaver suggested changes Jan 31, 2019
View reviewed changes
Copy link
Contributor

@tseaver tseaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a new test in 'tests/unit/test_job.py' which exercises passing explicit values for the new arguments.

shollyman
shollyman reviewed Jan 31, 2019
View reviewed changes
Copy link
Contributor

@shollyman shollyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per the test failures related to DDL, looks like you need to add the signature change to _EmptyRowIterator as well.

@tswast
Copy link
Contributor Author

tswast commented Feb 1, 2019

Needs a new test in 'tests/unit/test_job.py' which exercises passing explicit values for the new arguments.

Added in latest commit. Also added a unit test for the case of an empty iterator to catch the error caught in system tests in the unit tests.

shollyman
shollyman approved these changes Feb 1, 2019
View reviewed changes
Copy link
Contributor

@shollyman shollyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the additional tests!

@tseaver tseaver merged commit 92d76f8 into googleapis:master Feb 1, 2019
@tswast tswast deleted the bq-to-dataframe branch February 1, 2019 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shollyman shollyman shollyman approved these changes

@tseaver tseaver tseaver approved these changes

@alixhami alixhami Awaiting requested review from alixhami

@crwilcox crwilcox Awaiting requested review from crwilcox

Assignees
No one assigned
Labels
api: bigquery Issues related to the BigQuery API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tswast @tseaver @shollyman @googlebot