Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup client tests with method to create minimal table resource #7802

Merged
merged 2 commits into from
Apr 25, 2019
Merged

Cleanup client tests with method to create minimal table resource #7802

merged 2 commits into from
Apr 25, 2019

Conversation

tswast
Copy link
Contributor

@tswast tswast commented Apr 24, 2019

This removes a lot of repeated code that wasn't relevant to the actual tests.

tswast added 2 commits April 24, 2019 15:49
@tswast
Cleanup client tests with method to create minimal table resource
49bc9fe 
This removes a lot of repeated code that wasn't relevant to the actual
tests.
@tswast
Remove unused import.
b5a2290
@tswast tswast added testing api: bigquery Issues related to the BigQuery API. type: cleanup An internal cleanup or hygiene concern. labels Apr 24, 2019
@tswast tswast requested review from plamut and a team April 24, 2019 23:03
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 24, 2019
@lbristol88
Copy link
Contributor

LGTM!

@tswast tswast merged commit 8b18324 into googleapis:master Apr 25, 2019
@tswast tswast deleted the bq-make_table_resource branch April 25, 2019 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plamut plamut Awaiting requested review from plamut

Assignees
No one assigned
Labels
api: bigquery Issues related to the BigQuery API. cla: yes This human has signed the Contributor License Agreement. testing type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tswast @lbristol88 @googlebot