Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #797: support auto-adding timestamp to pubsub messages. #809

Merged
merged 3 commits into from
Apr 10, 2015
Merged

Issue #797: support auto-adding timestamp to pubsub messages. #809

merged 3 commits into from
Apr 10, 2015

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Apr 8, 2015

See #797.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 8, 2015
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 80503a8 on tseaver:797-pubsub-topic_publish_w_timestamp into 41b5b72 on GoogleCloudPlatform:master.

@tmatsuo
Copy link
Contributor

tmatsuo commented Apr 8, 2015

This is cool :) Thx!

@tseaver tseaver mentioned this pull request Apr 8, 2015
Closed
dhermes
dhermes reviewed Apr 9, 2015
View reviewed changes
gcloud/pubsub/topic.py
@@ -113,6 +122,8 @@ def publish(self, message, **attrs):
:rtype: str
:returns: message ID assigned by the server to the published message
"""
if self.add_timestamp_to_messages:
attrs['timestamp'] = '%sZ' % _NOW().isoformat()

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 627e0de on tseaver:797-pubsub-topic_publish_w_timestamp into f08e71b on GoogleCloudPlatform:master.

@tseaver
Copy link
Contributor Author

tseaver commented Apr 10, 2015

@dhermes comments addressed, PTAL.

@tseaver tseaver mentioned this pull request Apr 10, 2015
Merged
@dhermes
Copy link
Contributor

dhermes commented Apr 10, 2015

LGTM.

tseaver added a commit that referenced this pull request Apr 10, 2015
@tseaver
Merge pull request #809 from tseaver/797-pubsub-topic_publish_w_times…
028a15d 
…tamp

Issue #797: support auto-adding timestamp to pubsub messages.
@tseaver tseaver merged commit 028a15d into googleapis:master Apr 10, 2015
@tseaver tseaver deleted the 797-pubsub-topic_publish_w_timestamp branch April 10, 2015 19:42
@dhermes dhermes mentioned this pull request Jun 4, 2015
Merged
@tseaver tseaver mentioned this pull request Mar 17, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tseaver @coveralls @tmatsuo @dhermes @googlebot