Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Datastore: expose 'reserveIds' API. #8178

Merged
merged 5 commits into from
Jun 4, 2019
Merged

Datastore: expose 'reserveIds' API. #8178

merged 5 commits into from
Jun 4, 2019

Conversation

HemangChothani
Copy link
Contributor

Fixes: #7111

@HemangChothani HemangChothani requested a review from crwilcox as a code owner May 27, 2019 13:37
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 27, 2019
tseaver
tseaver suggested changes May 28, 2019
View reviewed changes
Copy link
Contributor

@tseaver tseaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch!

datastore/tests/unit/test_client.py Outdated Show resolved Hide resolved
datastore/tests/unit/test_client.py Outdated Show resolved Hide resolved
datastore/tests/unit/test_client.py Outdated Show resolved Hide resolved
datastore/tests/unit/test_client.py Outdated Show resolved Hide resolved
datastore/tests/unit/test_client.py Outdated Show resolved Hide resolved
datastore/google/cloud/datastore/client.py Outdated Show resolved Hide resolved
datastore/google/cloud/datastore/client.py Outdated Show resolved Hide resolved
datastore/google/cloud/datastore/client.py Outdated Show resolved Hide resolved
datastore/tests/unit/test_client.py Outdated Show resolved Hide resolved
@tseaver tseaver added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 28, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 28, 2019
@tseaver
Copy link
Contributor

tseaver commented May 28, 2019

Also, per line #117 of the Kokoro job for Datastore, please run nox -re black to appease the linter.

@tseaver tseaver changed the title Datastore: Fix expose 'reserveIds' at top level. Datastore: expose 'reserveIds' API. May 29, 2019
@tseaver
Copy link
Contributor

tseaver commented May 29, 2019

@HemangChothani Please don't mark a reviewer's requested changes as "resolved" until you've pushed the commit which adds the change. If you address the review comment by commenting back, let the reviewer mark it as resolved if she / he agrees with your reply.

@sduskis sduskis added the api: datastore Issues related to the Datastore API. label May 30, 2019
@tseaver tseaver added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 3, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 3, 2019
@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label Jun 4, 2019
@tseaver
Copy link
Contributor

tseaver commented Jun 4, 2019

The BigQuery Kokoro failure is unrelated (see #8212).

@tseaver tseaver merged commit 79b1024 into googleapis:master Jun 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tseaver tseaver tseaver requested changes

@crwilcox crwilcox Awaiting requested review from crwilcox

Assignees
No one assigned
Labels
api: datastore Issues related to the Datastore API. cla: yes This human has signed the Contributor License Agreement. 🚨 This issue needs some love.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Datastore: expose 'reserveIds' at top level.
6 participants
@HemangChothani @tseaver @sduskis @googlebot @yoshi-automation @yoshi-kokoro