Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent requests from hanging on SSL handshake issue by adding a max t.o. #8207

Merged
merged 3 commits into from
Jun 5, 2019

Conversation

crwilcox
Copy link
Contributor

@crwilcox crwilcox commented Jun 3, 2019

The auth library defaults to timeout of None, effectively having no timeout. This adds a default timeout of 5 minutes for all users of the core._http implementation

b/132819217

@crwilcox crwilcox requested a review from busunkim96 as a code owner June 3, 2019 20:18
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 3, 2019
@tseaver tseaver self-requested a review June 4, 2019 17:08
Copy link
Contributor

@tseaver tseaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've checked the google-auth bits, and they are fine (I was worried about seconds vs. milliseconds, but the library uses seconds).

core/google/cloud/client.py Outdated Show resolved Hide resolved
core/tests/unit/test_client.py Outdated Show resolved Hide resolved
@crwilcox crwilcox added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 4, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 4, 2019
@crwilcox crwilcox merged commit 1f5fcf7 into master Jun 5, 2019
@crwilcox crwilcox deleted the add-max-timeout-to-http-requests branch June 5, 2019 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants