Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Omnibus: don't pin 'google-api-core' in libs using 'google-cloud-core'. #8213

Merged
merged 1 commit into from
Jun 4, 2019
Merged

Omnibus: don't pin 'google-api-core' in libs using 'google-cloud-core'. #8213

merged 1 commit into from
Jun 4, 2019

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Jun 4, 2019

Apparently, at least some versions of pip treat the more relaxed version of the google-api-core pin in these packages as license to ignore the transitive, stricter pin in google-cloud-core 1.0.0.

Closes #8085.

@tseaver tseaver added api: storage Issues related to the Cloud Storage API. api: bigquery Issues related to the BigQuery API. api: dns Issues related to the Cloud DNS API. packaging api: cloudresourcemanager Issues related to the Resource Manager API. api: runtimeconfig Issues related to the Cloud Runtime Config API API. labels Jun 4, 2019
@tseaver tseaver requested review from crwilcox and busunkim96 June 4, 2019 17:26
@tseaver tseaver requested a review from tswast as a code owner June 4, 2019 17:26
@tseaver tseaver requested a review from a team June 4, 2019 17:26
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 4, 2019
@tseaver tseaver merged commit b6b5fbe into googleapis:master Jun 4, 2019
@tseaver tseaver deleted the 8085-bq-dns-rm-rtc-gcs-remove-api_core-pin branch June 4, 2019 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the BigQuery API. api: cloudresourcemanager Issues related to the Resource Manager API. api: dns Issues related to the Cloud DNS API. api: runtimeconfig Issues related to the Cloud Runtime Config API API. api: storage Issues related to the Cloud Storage API. cla: yes This human has signed the Contributor License Agreement. packaging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Storage: Update to 1.16.0 can cause google-cloud-core or google-api-core to fail.
4 participants