#825: Allow passing explicit connection to 'Bucket.{list_blobs,make public}' #856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
|
Ping me on this when we resolve #853 |
|
Rebased against updated branch for #853. |
|
Changes Unknown when pulling 1612c84 on tseaver:825-storage_bucket_list_blobs_make_public-explicit_connection into * on GoogleCloudPlatform:master*. |
|
Rebased again against updated branch for #853. |
|
@dhermes any remaining issues? |
|
Ditto here, was waiting on diffbase. |
|
OIC, you'd like a rebase against master. |
| def __init__(self, bucket, extra_params=None): | ||
| def __init__(self, bucket, extra_params=None, connection=None): | ||
| if connection is None: | ||
| connection = bucket.connection |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
Ideally, the backend would have a special-purpose ACL for blobs where they "inherit"/"acquire" the permissions from their bucket; one could then leave them in that state as they were created, and toggle them all public / private just by manipulating the bucket's ACL. |
|
Unfortunately that ideal doesn't exist. |
|
LGTM |
tseaver
added a commit
that referenced
this pull request
May 11, 2015
…ke_public-explicit_connection #825: Allow passing explicit connection to 'Bucket.{list_blobs,make public}'
tseaver
deleted the
825-storage_bucket_list_blobs_make_public-explicit_connection
branch
parthea
pushed a commit
that referenced
this pull request
Oct 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires #853.
See #825.