Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#825: Allow passing explicit connection to pubsub API methods #859

Merged
merged 9 commits into from
May 6, 2015
Merged

#825: Allow passing explicit connection to pubsub API methods #859

merged 9 commits into from
May 6, 2015

Commits on May 4, 2015

  1. Allow passing explicit connection to Topic API methods. 

    See #825.
    @tseaver
    tseaver committed May 4, 2015
    Configuration menu
    Copy the full SHA
    a2fde1d View commit details
    Browse the repository at this point in the history

  2. Rename 'pubsub.topic._Batch' -> 'Batch'. 

    Indicate that it can be constructed directly.
    @tseaver
    tseaver committed May 4, 2015
    Configuration menu
    Copy the full SHA
    5123ad2 View commit details
    Browse the repository at this point in the history

  3. Factor out timestamping for use in batch.

    @tseaver
    tseaver committed May 4, 2015
    Configuration menu
    Copy the full SHA
    ed3f33e View commit details
    Browse the repository at this point in the history

  4. Add explicit coverage for 'pubsub.topic.Batch'.

    @tseaver
    tseaver committed May 4, 2015
    Configuration menu
    Copy the full SHA
    c90730d View commit details
    Browse the repository at this point in the history

  5. Py3k / lint fixups.

    @tseaver
    tseaver committed May 4, 2015
    Configuration menu
    Copy the full SHA
    b9b3451 View commit details
    Browse the repository at this point in the history

  6. Allow passing explicit connection to 'pubsub.topic.Batch.commit'. 

    See #825.
    @tseaver
    tseaver committed May 4, 2015
    Configuration menu
    Copy the full SHA
    865191b View commit details
    Browse the repository at this point in the history

  7. Allow passing explicit connection to Subscription API methods. 

    See #825.
    @tseaver
    tseaver committed May 4, 2015
    Configuration menu
    Copy the full SHA
    b60cf16 View commit details
    Browse the repository at this point in the history

Commits on May 6, 2015

  1. Add helper for pubsub.

    @tseaver
    tseaver committed May 6, 2015
    Configuration menu
    Copy the full SHA
    d6edeb2 View commit details
    Browse the repository at this point in the history

  2. Expunge 'Topic.connection' property. 

    Adopt '_require_connection' pattern from storage.

Addresses:
#859 (comment)
    @tseaver
    tseaver committed May 6, 2015
    Configuration menu
    Copy the full SHA
    ad82cf7 View commit details
    Browse the repository at this point in the history