-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BigQuery: Use configurable bucket name for GCS samples data in systems tests. #8783
Conversation
This allows the VPC-SC team to use their private mirror which is within the security boundary when testing BigQuery VPC-SC support.
# The VPC-SC team maintains a mirror of the GCS bucket used for code | ||
# samples. The public bucket crosses the configured security boundary. | ||
# See: https://github.com/googleapis/google-cloud-python/issues/8550 | ||
SAMPLES_BUCKET = os.environ.get("GCLOUD_TEST_SAMPLES_BUCKET", "cloud-samples-data") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to update noxfile.py
to set this value in the environment?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, the default of cloud-samples-data
is fine for our purposes. The VPC-SC team has a separate Kokoro (or maybe something similar?) config where they'll set the necessary environment variable.
failure is unrelated. I think it's a behavior change / regression from |
@tswast How should we track that regression? All BigQuery CI is b0rked ATM. |
Let's pin to |
Sent #8784. |
This allows the VPC-SC team to use their private mirror which is within
the security boundary when testing BigQuery VPC-SC support.
Closes #8550.