Skip to content

Conversation

@dhermes
Copy link
Contributor

@dhermes dhermes commented May 26, 2015

Makes distinction between an iterable of keys and a single
key for get requests and re-purposes the get() name for the
single key case.

Fixes #701.

Makes distinction between an iterable of keys and a single
key for get requests and re-purposes the get() name for the
single key case.

Fixes googleapis#701.
@dhermes dhermes added the api: datastore Issues related to the Datastore API. label May 26, 2015
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 26, 2015
@jgeewax
Copy link
Contributor

jgeewax commented May 26, 2015

LGTM

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling d345186 on dhermes:fix-701-2nd-attempt into 6cf0852 on GoogleCloudPlatform:master.

@dhermes
Copy link
Contributor Author

dhermes commented May 26, 2015

@tseaver Care to weigh in?

@tseaver
Copy link
Contributor

tseaver commented May 26, 2015

Sorry -- I figured since I asked for it an @jgeewax OK'ed it, you were good to go. LGTM.

dhermes added a commit that referenced this pull request May 26, 2015
Implementing get_multi in datastore.
@dhermes dhermes merged commit 4dd4415 into googleapis:master May 26, 2015
@dhermes
Copy link
Contributor Author

dhermes commented May 26, 2015

@tseaver No worries. It wasn't pressing and I wanted to give you a chance to weigh in if you had any thoughts.

@dhermes dhermes deleted the fix-701-2nd-attempt branch May 26, 2015 18:48
parthea pushed a commit that referenced this pull request Aug 21, 2025
Source-Link: googleapis/synthtool@aa69fb7
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:f016446d6e520e5fb552c45b110cba3f217bffdd3d06bdddd076e9e6d13266cf

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Sep 16, 2025
Source-Link: googleapis/synthtool@aa69fb7
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:f016446d6e520e5fb552c45b110cba3f217bffdd3d06bdddd076e9e6d13266cf

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Sep 18, 2025
* chore(deps): update all dependencies

* Update docs.yml

* Update lint.yml

---------

Co-authored-by: Lingqing Gan <lingqing.gan@gmail.com>
parthea pushed a commit that referenced this pull request Nov 22, 2025
* feat: add new v3.0.0 API skeleton (#745)

* feat: improve rows filters (#751)

* feat: read rows query model class (#752)

* feat: implement row and cell model classes (#753)

* feat: add pooled grpc transport (#748)

* feat: implement read_rows (#762)

* feat: implement mutate rows (#769)

* feat: literal value filter (#767)

* feat: row_exists and read_row (#778)

* feat: read_modify_write and check_and_mutate_row (#780)

* feat: sharded read rows (#766)

* feat: ping and warm with metadata (#810)

* feat: mutate rows batching (#770)

* chore: restructure module paths (#816)

* feat: improve timeout structure (#819)

* fix: api errors apply to all bulk mutations

* chore: reduce public api surface (#820)

* feat: improve error group tracebacks on < py11 (#825)

* feat: optimize read_rows (#852)

* chore: add user agent suffix (#842)

* feat: optimize retries (#854)

* feat: add test proxy (#836)

* chore(tests): add conformance tests to CI for v3 (#870)

* chore(tests): turn off fast fail for conformance tets (#882)

* feat: add TABLE_DEFAULTS enum for table method arguments (#880)

* fix: pass None for retry in gapic calls (#881)

* feat: replace internal dictionaries with protos in gapic calls (#875)

* chore: optimize gapic calls (#863)

* feat: expose retryable error codes to users (#879)

* chore: update api_core submodule (#897)

* chore: merge main into experimental_v3 (#900)

* chore: pin conformance tests to v0.0.2 (#903)

* fix: bulk mutation eventual success (#909)

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Nov 24, 2025
Fixes #897 

The string ident changed to have an `_pb2` in #851. If there's a more robust way to do this comparison please let me know.
parthea pushed a commit that referenced this pull request Nov 24, 2025
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Nov 26, 2025
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Bu Sun Kim <8822365+busunkim96@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: datastore Issues related to the Datastore API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

datastore.get() requires a list

5 participants