Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: Fix documentation links for iam and error-reporting. #9073

Merged
merged 1 commit into from
Aug 23, 2019
Merged

Docs: Fix documentation links for iam and error-reporting. #9073

merged 1 commit into from
Aug 23, 2019

Conversation

busunkim96
Copy link
Contributor

Two more fixes to get the docs to be available at the DNS name. Will be followed by releases to get updated links on PyPI.

@busunkim96 busunkim96 requested a review from a team August 21, 2019 23:13
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 21, 2019
@busunkim96 busunkim96 added api: clouderrorreporting Issues related to the Error Reporting API. api: iam Issues related to the Identity and Access Management API. type: docs Improvement to the documentation for an API. labels Aug 21, 2019
plamut
plamut reviewed Aug 22, 2019
View reviewed changes
Copy link
Contributor

@plamut plamut left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The old URLs work for me, while the new ones do not (yet?), I get 404.
I presume this is a temporary state and these changes here require some other complementary changes to work?

Or if not, how can I verify that the new links are indeed correct? Thanks!

@busunkim96
Copy link
Contributor Author

@plamut I moved the docs in the backend, so now the links should work. :)

https://googleapis.dev/python/clouderrorreporting/latest/index.html
https://googleapis.dev/python/iamcredentials/latest/index.html

@busunkim96 busunkim96 merged commit d3b39e5 into googleapis:master Aug 23, 2019
HemangChothani pushed a commit to HemangChothani/google-cloud-python that referenced this pull request Aug 29, 2019
@busunkim96
Fix documentation links for iam and error-reporting. (googleapis#9073)
c17f2b7
emar-kar pushed a commit to MaxxleLLC/google-cloud-python that referenced this pull request Sep 18, 2019
@busunkim96 @emar-kar
Fix documentation links for iam and error-reporting. (googleapis#9073)
a1d4f8f
parthea pushed a commit that referenced this pull request Aug 15, 2023
@busunkim96
Fix documentation links for iam and error-reporting. (#9073)
e86caa0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plamut plamut plamut approved these changes

@tswast tswast tswast approved these changes

Assignees
No one assigned
Labels
api: clouderrorreporting Issues related to the Error Reporting API. api: iam Issues related to the Identity and Access Management API. cla: yes This human has signed the Contributor License Agreement. type: docs Improvement to the documentation for an API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@busunkim96 @tswast @plamut @googlebot