[CHANGE ME] Re-generated pubsub to pick up changes in the API or client library generator.

[yoshi-automation]

This PR was generated using Autosynth. 🌈

Here's the log from Synthtool:

synthtool > Executing /tmpfs/src/git/autosynth/working_repo/pubsub/synth.py.
synthtool > Ensuring dependencies.
synthtool > Pulling artman image.
latest: Pulling from googleapis/artman
Digest: sha256:38a27ba6245f96c3e86df7acb2ebcc33b4f186d9e475efe2d64303aec3d4e0ea
Status: Image is up to date for googleapis/artman:latest
synthtool > Cloning googleapis.
synthtool > Running generator for google/pubsub/artman_pubsub.yaml.
synthtool > Generated code into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/pubsub-v1.
synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/pubsub/v1/pubsub.proto to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/pubsub-v1/google/cloud/pubsub_v1/proto/pubsub.proto
synthtool > Placed proto files into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/pubsub-v1/google/cloud/pubsub_v1/proto.
synthtool > Replaced 'from google.cloud import pubsub_v1' in tests/unit/gapic/v1/test_publisher_client_v1.py.
synthtool > Replaced ' pubsub_v1' in tests/unit/gapic/v1/test_publisher_client_v1.py.
synthtool > Replaced 'from google.cloud import pubsub_v1' in tests/unit/gapic/v1/test_subscriber_client_v1.py.
synthtool > Replaced ' pubsub_v1' in tests/unit/gapic/v1/test_subscriber_client_v1.py.
synthtool > Replaced '# The name of the interface for this client. This is the key used to' in google/cloud/pubsub_v1/gapic/publisher_client.py.
synthtool > Replaced '# The name of the interface for this client. This is the key used to' in google/cloud/pubsub_v1/gapic/subscriber_client.py.
synthtool > Replaced 'import google.api_core.gapic_v1.method\n' in google/cloud/pubsub_v1/gapic/publisher_client.py.
synthtool > Replaced 'DESCRIPTOR = _MESSAGESTORAGEPOLICY,\n\\s+__module__.*\n\\s+,\n\\s+__doc__ = """' in google/cloud/pubsub_v1/proto/pubsub_pb2.py.
synthtool > No replacements made in google/cloud/pubsub_v1/gapic/subscriber_client.py for pattern subscription \(str\): The subscription whose backlog .*
(.*
)+?\s+Format is .*, maybe replacement is not longer needed?
synthtool > Replaced 'import functools\n' in google/cloud/pubsub_v1/gapic/publisher_client.py.
synthtool > Replaced 'import pkg_resources\n' in google/cloud/pubsub_v1/gapic/publisher_client.py.
synthtool > Replaced 'class PublisherClient' in google/cloud/pubsub_v1/gapic/publisher_client.py.
synthtool > Replaced 'client_config \\(dict\\): DEPRECATED.' in google/cloud/pubsub_v1/gapic/publisher_client.py.
synthtool > Replaced '# Raise deprecation warnings .*\n.*\n.*\n.*\n.*\n.*\n' in google/cloud/pubsub_v1/gapic/publisher_client.py.
synthtool > Replaced '~google.api_core.page_iterator.PageIterator' in google/cloud/pubsub_v1/gapic/publisher_client.py.
synthtool > Replaced '~google.api_core.page_iterator.PageIterator' in google/cloud/pubsub_v1/gapic/subscriber_client.py.
synthtool > Replaced 'from google.iam.v1 import iam_policy_pb2' in google/cloud/pubsub_v1/gapic/transports/publisher_grpc_transport.py.
synthtool > Replaced 'from google.iam.v1 import iam_policy_pb2' in google/cloud/pubsub_v1/gapic/transports/subscriber_grpc_transport.py.
.coveragerc
.flake8
MANIFEST.in
noxfile.py.j2
setup.cfg
Running session blacken
Creating virtual environment (virtualenv) using python3.6 in .nox/blacken
pip install black==19.3b0
black docs google tests noxfile.py setup.py
reformatted /tmpfs/src/git/autosynth/working_repo/pubsub/google/cloud/__init__.py
reformatted /tmpfs/src/git/autosynth/working_repo/pubsub/google/__init__.py
reformatted /tmpfs/src/git/autosynth/working_repo/pubsub/google/cloud/pubsub.py
reformatted /tmpfs/src/git/autosynth/working_repo/pubsub/google/cloud/pubsub_v1/gapic/subscriber_client_config.py
reformatted /tmpfs/src/git/autosynth/working_repo/pubsub/google/cloud/pubsub_v1/gapic/publisher_client_config.py
reformatted /tmpfs/src/git/autosynth/working_repo/pubsub/google/cloud/pubsub_v1/gapic/transports/publisher_grpc_transport.py
reformatted /tmpfs/src/git/autosynth/working_repo/pubsub/google/cloud/pubsub_v1/gapic/transports/subscriber_grpc_transport.py
reformatted /tmpfs/src/git/autosynth/working_repo/pubsub/google/cloud/pubsub_v1/gapic/subscriber_client.py
reformatted /tmpfs/src/git/autosynth/working_repo/pubsub/google/cloud/pubsub_v1/gapic/publisher_client.py
reformatted /tmpfs/src/git/autosynth/working_repo/pubsub/google/cloud/pubsub_v1/proto/pubsub_pb2_grpc.py
reformatted /tmpfs/src/git/autosynth/working_repo/pubsub/tests/system/gapic/v1/test_system_publisher_v1.py
reformatted /tmpfs/src/git/autosynth/working_repo/pubsub/noxfile.py
reformatted /tmpfs/src/git/autosynth/working_repo/pubsub/tests/unit/gapic/v1/test_publisher_client_v1.py
reformatted /tmpfs/src/git/autosynth/working_repo/pubsub/tests/unit/gapic/v1/test_subscriber_client_v1.py
reformatted /tmpfs/src/git/autosynth/working_repo/pubsub/google/cloud/pubsub_v1/proto/pubsub_pb2.py
All done! ✨ 🍰 ✨
15 files reformatted, 49 files left unchanged.
Session blacken was successful.
synthtool > Cleaned up 3 temporary directories.
synthtool > Wrote metadata to synth.metadata.

[plamut]

The changes seem fine on the surface, but this is the first time I see this, and cannot say for certain whether this change is intended or not, and what the requirements are. Will seek for more info.

@anguillanneuf Do you know anything about this new thing?

[anguillanneuf]

@plamut Yes, I'm aware. This is a private alpha feature for now. The goal for this feature is to offload bad messages to a separate topic so they don't clog up the system.

[anguillanneuf]

Thanks for the ping. LGTM.

[plamut]

Oh... I should have edited the merge message, meh. :/
Sorry!

[TrangPham]

When would this feature be available to end users?

[plamut]

@TrangPham I think the target is Q1 2020 - but please consider that an unofficial answer for now.

(cc: @hongalex)