-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AutoML Tables: Enable users to pass in Pandas Dataframe when calling import_data() and batch_predict() from AutoML Tables client #9116
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG! Just a few small comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👋 I'm not completely sold on the added value of this wrapper. Perhaps this would be better suited for a sample than a library method? @sirtorry?
We want to simplify the experience for datascientists in jupyter notebooks as much as possible. Typically they are doing feature engineering & data-processing on dataframes, and we don't want them to have to copy-paste a sample or learn to use another client library for simple things like this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First wave of comments resolved 😃 !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 2 last comments from my end
…nd batch_predict() from AutoML Tables client (googleapis#9116)
…nd batch_predict() from AutoML Tables client (googleapis#9116)
…nd batch_predict() from AutoML Tables client (#9116)
This PR:
pandas_dataframe
toimport_data()
andbatch_predict()
of the Tables client.