-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release bigquery 1.19.0 #9137
Release bigquery 1.19.0 #9137
Conversation
Co-Authored-By: Tres Seaver <tseaver@palladion.com>
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
Co-Authored-By: Tres Seaver <tseaver@palladion.com>
Co-Authored-By: Tres Seaver <tseaver@palladion.com>
A Googler has manually verified that the CLAs look good. (Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.) ℹ️ Googlers: Go here for more info. |
Sorry, I didn't see this open PR and I just merged a new feature for BigQuery. #9084 Can we add that commit to the changelog, too? |
P.S. I didn't really want to release 1.19.0 without that commit, because otherwise there's a regression where it's impossible to write a DataFrame's indexes to a BigQuery table if |
08-28-2019 09:35 PDT | ||
|
||
### Implementation Changes | ||
- Deprecate `client.dataset()` part 1 ([#9032](https://github.com/googleapis/google-cloud-python/pull/9032)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd very much like a different message for this. It's not actually a deprecation yet. We just updated some samples to remove references to client.dataset()
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's move this to the "docs" section and say "Updated code samples to use strings for table and dataset IDs."
### Implementation Changes | ||
- Deprecate `client.dataset()` part 1 ([#9032](https://github.com/googleapis/google-cloud-python/pull/9032)) | ||
- Raise with extra or missing columns in `load_table_from_dataframe` schema. ([#9096](https://github.com/googleapis/google-cloud-python/pull/9096)) | ||
- Allow subset of schema to be passed into `load_table_from_dataframe`. ([#9064](https://github.com/googleapis/google-cloud-python/pull/9064)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Allow subset of schema...
This is definitely a new feature.
@tswast sounds good, I'll open a new PR with the new commit and a corrected Changelog. Thanks! |
This pull request was generated using releasetool.