Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release bigquery 1.19.0 #9137

Closed

Conversation

busunkim96
Copy link
Contributor

This pull request was generated using releasetool.

@busunkim96 busunkim96 requested a review from a team August 28, 2019 16:41
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 28, 2019
bigquery/CHANGELOG.md Outdated Show resolved Hide resolved
bigquery/CHANGELOG.md Outdated Show resolved Hide resolved
bigquery/CHANGELOG.md Outdated Show resolved Hide resolved
Co-Authored-By: Tres Seaver <tseaver@palladion.com>
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Aug 28, 2019
busunkim96 and others added 2 commits August 28, 2019 12:25
Co-Authored-By: Tres Seaver <tseaver@palladion.com>
Co-Authored-By: Tres Seaver <tseaver@palladion.com>
@busunkim96 busunkim96 added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Aug 28, 2019
@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Aug 28, 2019
@tswast
Copy link
Contributor

tswast commented Aug 28, 2019

Sorry, I didn't see this open PR and I just merged a new feature for BigQuery. #9084

Can we add that commit to the changelog, too?

@tswast
Copy link
Contributor

tswast commented Aug 28, 2019

P.S. I didn't really want to release 1.19.0 without that commit, because otherwise there's a regression where it's impossible to write a DataFrame's indexes to a BigQuery table if pyarrow is installed.

08-28-2019 09:35 PDT

### Implementation Changes
- Deprecate `client.dataset()` part 1 ([#9032](https://github.com/googleapis/google-cloud-python/pull/9032))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd very much like a different message for this. It's not actually a deprecation yet. We just updated some samples to remove references to client.dataset().

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's move this to the "docs" section and say "Updated code samples to use strings for table and dataset IDs."

### Implementation Changes
- Deprecate `client.dataset()` part 1 ([#9032](https://github.com/googleapis/google-cloud-python/pull/9032))
- Raise with extra or missing columns in `load_table_from_dataframe` schema. ([#9096](https://github.com/googleapis/google-cloud-python/pull/9096))
- Allow subset of schema to be passed into `load_table_from_dataframe`. ([#9064](https://github.com/googleapis/google-cloud-python/pull/9064))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Allow subset of schema...

This is definitely a new feature.

@busunkim96
Copy link
Contributor Author

@tswast sounds good, I'll open a new PR with the new commit and a corrected Changelog. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autorelease: closed cla: no This human has *not* signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants