BigQuery: Change the default value of Cursor instances' arraysize attribute to None #9199
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9185.
This PR adds a note on
arraysize
parameter, and its impact on thefetchall()
method performance.To discuss
Following a comment on the issue, should we reanimate thefetchmany()
'ssize
parameter, too?No (for the time being), as that would require implementing a custom pagination logic in the client (comment).
How to test
Run the code sample from the issue description, and verify that by settingcursor.arraysize
to appropriate value avoids the reported performance issue, which what the updated docs point out.Run the code sample from the issue description, and verify that the new default value of
cursor.arraysize
avoids the reported performance issue. Or setting that value manually to something appropriate.