-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(pubsub): split large (mod)ACK requests into smaller ones #9594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
This human has signed the Contributor License Agreement.
label
Nov 4, 2019
plamut
commented
Nov 4, 2019
There is a server-side limit on the maximum size of ACK and modACK requests, which can be hit if the leaser tries to manage too many messages in a single requests. This commit assures that such large requests are split into multiple smaller requests.
There might still be an issue here, do not merge yet... Update: Contrary to Node.js, 3000 appears is too high a limit in Python, thus had to reduce it. |
plamut
added
the
do not merge
Indicates a pull request not ready for merge, due to either quality or timing.
label
Nov 4, 2019
The previous limit of 3000 seems to be too optimistic, and the request size limit is still hit. Reducing the batch size to 2500 fixes the problem.
plamut
removed
the
do not merge
Indicates a pull request not ready for merge, due to either quality or timing.
label
Nov 4, 2019
pradn
reviewed
Nov 22, 2019
pradn
reviewed
Nov 22, 2019
pradn
reviewed
Nov 22, 2019
pradn
reviewed
Nov 22, 2019
pradn
reviewed
Nov 22, 2019
pradn
suggested changes
Nov 22, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there's a bug in splitting. Otherwise, looks good.
The tests should also check that each message is (MOD)ACK-ed exactly once.
pradn
approved these changes
Nov 22, 2019
This was referenced Jan 29, 2020
[CHANGE ME] Re-generated container to pick up changes in the API or client library generator.
#10256
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api: pubsub
Issues related to the Pub/Sub API.
cla: yes
This human has signed the Contributor License Agreement.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9103.
There is a server-side limit on the maximum size of ACK and modACK requests, which can be hit if the leaser tries to manage too many messages in a single requests. This PR avoids the problem by splitting such large requests into multiple smaller requests.
How to test
Steps to reproduce:
Actual result (before the fix):
The following error can be observed in the log output:
Expected result (after the fix):
There is no error, mass-acknowledging leased messages works just fine.
The following script might come helpful:
reproduce_9103.py