Remove storage.api module and move methods onto client #973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Essentially just copied and pasted from storage.api, with a few tweaks for docstring typos. Only implemented 2 of 3 tests for each method since the third tests were for the case of an implicit connection.
googlebot
added
the
cla: yes
7 tasks
|
@tseaver PTAL |
|
PR LGTM overall. |
|
w00t! |
dhermes
added a commit
that referenced
this pull request
Jul 10, 2015
Remove storage.api module and move methods onto client
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #952.
@tseaver LMK if you want me to break this into separate PRs. I tried my best to make each commit as small a scope as possible to aid in review.