Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(bigquery): run unit tests with Python 3.8 #9880

Merged
merged 3 commits into from
Dec 2, 2019

Conversation

tswast
Copy link
Contributor

@tswast tswast commented Nov 21, 2019

I had to decrease the required per-version coverage on account of the missing pyarrow dependency.

Towards #9878

Coverage is a bit low because of the missing pyarrow dependency.
@tswast tswast requested a review from a team November 21, 2019 23:01
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 21, 2019
@tswast tswast requested a review from plamut November 21, 2019 23:01
@tswast
Copy link
Contributor Author

tswast commented Nov 21, 2019

I've filed https://github.com/googleapis/google-cloud-python/issues/9881 to track removing the Python 3.8-specific updates in the noxfile once all dependencies are available.

Copy link
Contributor

@plamut plamut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good, and the tests run under Python 3.8, albeit with a lot of them skipped for the time being.

We might need to lower the coverage threshold, though, I got a coverage failure when running the session unit-3.8 (total coverage 92.90%, required 93%). That was after removing the .coverage file first.

bigquery/noxfile.py Outdated Show resolved Hide resolved
bigquery/tests/unit/test__pandas_helpers.py Show resolved Hide resolved
Copy link
Contributor

@plamut plamut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The additional comments look good. 👍

However, I now cannot verify the PR, as the nox setup phase fails with numpy import errors, and complaining that LLVM version 7.0+ is needed (I seem to have 6.0.0 installed).

Could be just my specific environment, but I did not dig further. Could perhaps somebody else try on their machine?

BTW, the coverage check (still) seems to fail on Kokoro...

@tswast
Copy link
Contributor Author

tswast commented Nov 23, 2019

From Kokoro:

Session unit-3.8 skipped: Python interpreter 3.8 not found.

I'll send a PR to the test containers repo to see if I can get this in our multi-Python image. googleapis/testing-infra-docker#44

@tswast tswast added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 23, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 23, 2019
@tswast tswast added the kokoro:run Add this label to force Kokoro to re-run the tests. label Nov 25, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Nov 25, 2019
@tswast tswast requested a review from busunkim96 November 25, 2019 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants