Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrading pubsub to v1. #996

Merged
merged 1 commit into from
Jul 20, 2015
Merged

Upgrading pubsub to v1. #996

merged 1 commit into from
Jul 20, 2015

Conversation

dhermes
Copy link
Contributor

@dhermes dhermes commented Jul 14, 2015

Fixes #957.

/cc @tmatsuo

@dhermes dhermes added the api: pubsub Issues related to the Pub/Sub API. label Jul 14, 2015
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 14, 2015
@tmatsuo
Copy link
Contributor

tmatsuo commented Jul 14, 2015

LGTM

@dhermes
Copy link
Contributor Author

dhermes commented Jul 14, 2015

Will wait for @tseaver sign-off before merging. Thanks for the lookover Takashi

@tseaver
Copy link
Contributor

tseaver commented Jul 20, 2015

LGTM

dhermes added a commit that referenced this pull request Jul 20, 2015
@dhermes
Merge pull request #996 from dhermes/upgrade-pubsub-version
8522653 
Upgrading pubsub to v1.
@dhermes dhermes merged commit 8522653 into googleapis:master Jul 20, 2015
@dhermes dhermes deleted the upgrade-pubsub-version branch July 20, 2015 18:32
@dhermes dhermes mentioned this pull request Jul 21, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api: pubsub Issues related to the Pub/Sub API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dhermes @tmatsuo @tseaver @googlebot