fix(bigquery): Avoid dataset reload when accessing location (#22905)

googleapis · Sep 11, 2023 · a2b85cf · a2b85cf
1 parent cfa2ab1
commit a2b85cf
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 4 deletions.
diff --git a/google-cloud-bigquery/lib/google/cloud/bigquery/dataset.rb b/google-cloud-bigquery/lib/google/cloud/bigquery/dataset.rb
@@ -269,7 +269,6 @@ def modified_at
         #
         def location
           return nil if reference?
-          ensure_full_data!
           @gapi.location
         end
 

diff --git a/google-cloud-bigquery/test/google/cloud/bigquery/dataset_attributes_test.rb b/google-cloud-bigquery/test/google/cloud/bigquery/dataset_attributes_test.rb
@@ -95,6 +95,4 @@ def self.attr_test attr, val
   attr_test :default_expiration, 999
   attr_test :etag, "etag123456789"
   attr_test :api_url, "http://googleapi/bigquery/v2/projects/test-project/datasets/my_dataset"
-  attr_test :location, "US"
-
 end
diff --git a/google-cloud-bigquery/test/helper.rb b/google-cloud-bigquery/test/helper.rb
@@ -113,7 +113,8 @@ def random_dataset_partial_hash id = nil, name = nil
         "datasetId" => id,
         "projectId" => project
       },
-      "friendlyName" => name
+      "friendlyName" => name,
+      "location": "US"
     }
   end