-
Notifications
You must be signed in to change notification settings - Fork 554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(datastore): Added support for snapshot read #19422
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: datastore
Issues related to the Datastore API.
label
Nov 15, 2022
diptanshumittal
force-pushed
the
feat_datastore_snapshot_read
branch
from
December 1, 2022 10:13
b8d017c
to
c3fa354
Compare
diptanshumittal
force-pushed
the
feat_datastore_snapshot_read
branch
from
December 1, 2022 11:55
639e465
to
a57677a
Compare
bajajneha27
reviewed
Dec 19, 2022
SandeepTuniki
suggested changes
Feb 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some changes needed from code maintenance pov. Functionality looks good to me.
…gleapis/google-cloud-ruby into feat_datastore_snapshot_read
# Conflicts: # google-cloud-datastore/lib/google/cloud/datastore/service.rb # google-cloud-datastore/test/helper.rb
diptanshumittal
force-pushed
the
feat_datastore_snapshot_read
branch
from
February 9, 2023 15:31
101311d
to
eae8ddc
Compare
SandeepTuniki
approved these changes
Feb 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.