ci: Add Java Smoke Tests #477
Conversation
product-auto-label
bot
added
the
api: eventarc
averikitsch
force-pushed
the
java-tests
branch
from
edbcb83 to
90aca67
Compare
averikitsch
force-pushed
the
java-tests
branch
from
90aca67 to
91dd5f3
Compare
| path: ${{ env.LIBRARY_CHECKOUT_PATH }} | ||
| ref: snowpea-build | ||
|
|
||
| - name: Proto Schemas > Checkout Repository |
There was a problem hiding this comment.
I wonder if we could do a single checkout of proto schemas and reuse across all languages?
There was a problem hiding this comment.
I don't think it's worth the work trying to create a parent job to checkout and have child jobs uses that one source. Are you concerned or just trying to minimize each language setup?
There was a problem hiding this comment.
Just thinking about avoiding redundant actions and per-language complexity. But agreed, refactoring for that is a good future improvement.
.github/workflows/test_clients.yaml
Outdated
| with: | ||
| repository: googleapis/google-cloudevents-java | ||
| path: ${{ env.LIBRARY_CHECKOUT_PATH }} | ||
| ref: snowpea-build |
There was a problem hiding this comment.
Note to self: remove before merging
| path: ${{ env.LIBRARY_CHECKOUT_PATH }} | ||
| ref: snowpea-build | ||
|
|
||
| - name: Proto Schemas > Checkout Repository |
There was a problem hiding this comment.
Just thinking about avoiding redundant actions and per-language complexity. But agreed, refactoring for that is a good future improvement.
No description provided.